Re: [PATCH] btrfs: migrate extent_buffer::pages[] to folio

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

On 2023/11/30 02:32, David Sterba wrote:
> On Tue, Nov 28, 2023 at 08:47:33AM +1030, Qu Wenruo wrote:
>>
>>
>> On 2023/11/28 03:02, Josef Bacik wrote:
>>> On Mon, Nov 27, 2023 at 08:48:45AM +1030, Qu Wenruo wrote:
>>>> For now extent_buffer::pages[] are still only accept single page
>>>> pointer, thus we can migrate to folios pretty easily.
>>>>
>>>> As for single page, page and folio are 1:1 mapped.
>>>>
>>>> This patch would just do the conversion from struct page to struct
>>>> folio, providing the first step to higher order folio in the future.
>>>>
>>>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>>>
>>> This doesn't apply to misc-next cleanly, so I can't do my normal review, but
>>> just swapping us over to the folio stuff in name everywhere is a valuable first
>>> start.  I'd like to see this run through our testing infrastructure to make sure
>>> nothing got missed.  Once you can get it to apply cleanly somewhere and validate
>>> nothing weird got broken you can add
>>>
>>> Reviewed-by: Josef Bacik <josef@toxicpanda.com>
>>
>> Thanks, the failed apply is due to the fact that this relies on another
>> patch: "btrfs: refactor alloc_extent_buffer() to allocate-then-attach
>> method".
>
> V3 of the patch has a comment from Josef, please send an update so I can
> apply both patches and we can start testing the folio conversion.
>

For the folio conversion, I'd like to add more cleanups, mostly related
to bio_add_page() -> bio_add_folio() and page flags conversion.

Those are pretty safe as long as we're only using order 0 pages.

But the more conversion I have done in this patch, the less I need to do
in the final patch introducing the higher order folios.

Thanks,
Qu