[PATCH] btrfs: fix function name in comment for btrfs_remove_ordered_extent()

[PATCH] btrfs: fix function name in comment for btrfs_remove_ordered_extent()

[fdmanana]

From: Filipe Manana <fdmanana@suse.com>

Due to a refactoring introduced by commit 53d9981ca20e ("btrfs: split
btrfs_alloc_ordered_extent to allocation and insertion helpers"), the
function btrfs_alloc_ordered_extent() was renamed to
alloc_ordered_extent(), so the comment at btrfs_remove_ordered_extent()
is no longer very accurate. Update the comment to refer to the new
name "alloc_ordered_extent()".

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 fs/btrfs/ordered-data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
index a6c2b4e5edf1..d7c59bf924fd 100644
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -595,7 +595,7 @@ void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,
 	freespace_inode = btrfs_is_free_space_inode(btrfs_inode);
 
 	btrfs_lockdep_acquire(fs_info, btrfs_trans_pending_ordered);
-	/* This is paired with btrfs_alloc_ordered_extent. */
+	/* This is paired with alloc_ordered_extent(). */
 	spin_lock(&btrfs_inode->lock);
 	btrfs_mod_outstanding_extents(btrfs_inode, -1);
 	spin_unlock(&btrfs_inode->lock);
-- 
2.43.0

Re: [PATCH] btrfs: fix function name in comment for btrfs_remove_ordered_extent()

[David Sterba]

On Tue, May 14, 2024 at 03:26:23PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Due to a refactoring introduced by commit 53d9981ca20e ("btrfs: split
> btrfs_alloc_ordered_extent to allocation and insertion helpers"), the
> function btrfs_alloc_ordered_extent() was renamed to
> alloc_ordered_extent(), so the comment at btrfs_remove_ordered_extent()
> is no longer very accurate. Update the comment to refer to the new
> name "alloc_ordered_extent()".
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: David Sterba <dsterba@suse.com>

Re: [PATCH] btrfs: fix function name in comment for btrfs_remove_ordered_extent()

[Qu Wenruo]

在 2024/5/14 23:56, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> Due to a refactoring introduced by commit 53d9981ca20e ("btrfs: split
> btrfs_alloc_ordered_extent to allocation and insertion helpers"), the
> function btrfs_alloc_ordered_extent() was renamed to
> alloc_ordered_extent(), so the comment at btrfs_remove_ordered_extent()
> is no longer very accurate. Update the comment to refer to the new
> name "alloc_ordered_extent()".
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>   fs/btrfs/ordered-data.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
> index a6c2b4e5edf1..d7c59bf924fd 100644
> --- a/fs/btrfs/ordered-data.c
> +++ b/fs/btrfs/ordered-data.c
> @@ -595,7 +595,7 @@ void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,
>   	freespace_inode = btrfs_is_free_space_inode(btrfs_inode);
>
>   	btrfs_lockdep_acquire(fs_info, btrfs_trans_pending_ordered);
> -	/* This is paired with btrfs_alloc_ordered_extent. */
> +	/* This is paired with alloc_ordered_extent(). */
>   	spin_lock(&btrfs_inode->lock);
>   	btrfs_mod_outstanding_extents(btrfs_inode, -1);
>   	spin_unlock(&btrfs_inode->lock);