From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: do not check ram_bytes for non-compressed data extents
Date: Tue, 25 Jun 2024 17:13:07 +0200 [thread overview]
Message-ID: <20240625151307.GV25756@twin.jikos.cz> (raw)
In-Reply-To: <4ba45162892b90a9a7e9603df9705080e5292f47.1718965319.git.wqu@suse.com>
On Fri, Jun 21, 2024 at 07:52:06PM +0930, Qu Wenruo wrote:
> This patch reverts the following 3 commits:
> d0cc40d23aa0 ("btrfs-progs: tests: add test case for ram_bytes detection and repair")
> 7313573c1942 ("btrfs-progs: check: original, detect and repair ram_bytes mismatch")
> 97bf7a596900 ("btrfs-progs: check: lowmem, detect and repair mismatched ram_bytes")
>
> The problem with the ram_bytes check is, kernel can handle it without
> any problem, and the original objective for this is to detect such
> problem as I immaturelly believe the problem is fixed.
>
> But it turns out to be incorrect and this check is already causing
> problems.
>
> Fix it by doing a full revert for now.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to devel, thanks.
next prev parent reply other threads:[~2024-06-25 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 10:22 [PATCH] btrfs-progs: do not check ram_bytes for non-compressed data extents Qu Wenruo
2024-06-25 15:13 ` David Sterba [this message]
2024-06-25 22:44 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625151307.GV25756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox