Re: [PATCH] btrfs-progs: do not check ram_bytes for non-compressed data extents

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2024/6/26 00:43, David Sterba 写道:
> On Fri, Jun 21, 2024 at 07:52:06PM +0930, Qu Wenruo wrote:
>> This patch reverts the following 3 commits:
>> d0cc40d23aa0 ("btrfs-progs: tests: add test case for ram_bytes detection and repair")
>> 7313573c1942 ("btrfs-progs: check: original, detect and repair ram_bytes mismatch")
>> 97bf7a596900 ("btrfs-progs: check: lowmem, detect and repair mismatched ram_bytes")
>>
>> The problem with the ram_bytes check is, kernel can handle it without
>> any problem, and the original objective for this is to detect such
>> problem as I immaturelly believe the problem is fixed.
>>
>> But it turns out to be incorrect and this check is already causing
>> problems.
>>
>> Fix it by doing a full revert for now.
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>
> Added to devel, thanks.
>

Just to mention, thankfully the root cause is found and the fix is
pretty small.

However I would still prefer to do the revert. Even with "minor errors"
mentioning, end users are still confused and asking for help.

So the lesson here is, we should really not to bother non-corruption
on-disk format violation in btrfs-check.
Just let kernel fix them silently, and with enough time they should
disappear anyway.

Thanks,
Qu