[PATCH] btrfs: Fix typo in error message

[PATCH] btrfs: Fix typo in error message

[Mark Harmstone]

Signed-off-by: Mark Harmstone <maharmstone@fb.com>
---
 fs/btrfs/disk-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index d0882536b923..9b1ac0e2cdf3 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2467,7 +2467,7 @@ int btrfs_validate_super(struct btrfs_fs_info *fs_info,
 	    (!btrfs_fs_compat_ro(fs_info, FREE_SPACE_TREE_VALID) ||
 	     !btrfs_fs_incompat(fs_info, NO_HOLES))) {
 		btrfs_err(fs_info,
-		"block-group-tree feature requires fres-space-tree and no-holes");
+		"block-group-tree feature requires free-space-tree and no-holes");
 		ret = -EINVAL;
 	}
 
-- 
2.43.0

Re: [PATCH] btrfs: Fix typo in error message

[Filipe Manana]

On Thu, Jun 20, 2024 at 4:05 PM Mark Harmstone <maharmstone@fb.com> wrote:
>
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>

Please provide a change log, no matter how trivial a patch is, it
should always have one.
Something like for example:

"There's a typo in an error message when checking the block group tree feature,
it mentions fres-space-tree instead of free-space-tree. Fix that."

Also, in the subject don't capitalize the first word, it's the style
we follow for all commit subjects.
Could also make the subject less generic like:

btrfs: fix typo in error message when validating the block-group-tree feature

Thanks.

> ---
>  fs/btrfs/disk-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index d0882536b923..9b1ac0e2cdf3 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2467,7 +2467,7 @@ int btrfs_validate_super(struct btrfs_fs_info *fs_info,
>             (!btrfs_fs_compat_ro(fs_info, FREE_SPACE_TREE_VALID) ||
>              !btrfs_fs_incompat(fs_info, NO_HOLES))) {
>                 btrfs_err(fs_info,
> -               "block-group-tree feature requires fres-space-tree and no-holes");
> +               "block-group-tree feature requires free-space-tree and no-holes");
>                 ret = -EINVAL;
>         }
>
> --
> 2.43.0
>
>

Re: [PATCH] btrfs: Fix typo in error message

[David Sterba]

On Thu, Jun 20, 2024 at 04:04:51PM +0100, Mark Harmstone wrote:
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>

Thanks, I've added the patch to for-next with fixups suggested by
Filipe.