* [PATCH] btrfs/318: add _require_loop
@ 2024-10-10 15:36 Mark Harmstone
2024-10-10 15:52 ` Filipe Manana
2024-10-11 5:42 ` Zorro Lang
0 siblings, 2 replies; 3+ messages in thread
From: Mark Harmstone @ 2024-10-10 15:36 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs, Mark Harmstone
btrfs/318 uses loopback devices, but was missing a call to _require_loop
to print the correct message if CONFIG_LOOP is not set.
Signed-off-by: Mark Harmstone <maharmstone@fb.com>
---
tests/btrfs/318 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/btrfs/318 b/tests/btrfs/318
index 79977276..df5a4a07 100755
--- a/tests/btrfs/318
+++ b/tests/btrfs/318
@@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \
_require_test
_require_command "$PARTED_PROG" parted
_require_batched_discard "$TEST_DIR"
+_require_loop
_cleanup() {
cd /
--
2.44.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs/318: add _require_loop
2024-10-10 15:36 [PATCH] btrfs/318: add _require_loop Mark Harmstone
@ 2024-10-10 15:52 ` Filipe Manana
2024-10-11 5:42 ` Zorro Lang
1 sibling, 0 replies; 3+ messages in thread
From: Filipe Manana @ 2024-10-10 15:52 UTC (permalink / raw)
To: Mark Harmstone; +Cc: fstests, linux-btrfs
On Thu, Oct 10, 2024 at 4:46 PM Mark Harmstone <maharmstone@fb.com> wrote:
>
> btrfs/318 uses loopback devices, but was missing a call to _require_loop
> to print the correct message if CONFIG_LOOP is not set.
>
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Looks good, thanks.
> ---
> tests/btrfs/318 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/btrfs/318 b/tests/btrfs/318
> index 79977276..df5a4a07 100755
> --- a/tests/btrfs/318
> +++ b/tests/btrfs/318
> @@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \
> _require_test
> _require_command "$PARTED_PROG" parted
> _require_batched_discard "$TEST_DIR"
> +_require_loop
>
> _cleanup() {
> cd /
> --
> 2.44.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs/318: add _require_loop
2024-10-10 15:36 [PATCH] btrfs/318: add _require_loop Mark Harmstone
2024-10-10 15:52 ` Filipe Manana
@ 2024-10-11 5:42 ` Zorro Lang
1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2024-10-11 5:42 UTC (permalink / raw)
To: Mark Harmstone; +Cc: fstests, linux-btrfs
On Thu, Oct 10, 2024 at 04:36:25PM +0100, Mark Harmstone wrote:
> btrfs/318 uses loopback devices, but was missing a call to _require_loop
> to print the correct message if CONFIG_LOOP is not set.
>
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
> ---
> tests/btrfs/318 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/btrfs/318 b/tests/btrfs/318
> index 79977276..df5a4a07 100755
> --- a/tests/btrfs/318
> +++ b/tests/btrfs/318
> @@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \
> _require_test
> _require_command "$PARTED_PROG" parted
> _require_batched_discard "$TEST_DIR"
> +_require_loop
Sure, this case need loop device.
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> _cleanup() {
> cd /
> --
> 2.44.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-11 5:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-10 15:36 [PATCH] btrfs/318: add _require_loop Mark Harmstone
2024-10-10 15:52 ` Filipe Manana
2024-10-11 5:42 ` Zorro Lang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox