* [PATCH] btrfs: fix comment in reserved space warning
@ 2025-04-15 0:25 Dan Johnson
2025-05-24 17:31 ` Dan Johnson
0 siblings, 1 reply; 3+ messages in thread
From: Dan Johnson @ 2025-04-15 0:25 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba
Cc: Qu Wenruo, linux-btrfs, Dan Johnson
mkfs.btrfs up to v4.14 actually can leave a chunk inside the reserved
space when invoked with `-m single`, fixed by 997f9977c24397eb6980bb9
("mkfs: Prevent temporary system chunk to use space in reserved 1M
range") released with v4.15.
Signed-off-by: Dan Johnson <ComputerDruid@gmail.com>
---
fs/btrfs/volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 4d5c5908300..28521015d01 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -7989,7 +7989,7 @@ static int verify_one_dev_extent(struct btrfs_fs_info *fs_info,
}
/*
- * Very old mkfs.btrfs (before v4.1) will not respect the reserved
+ * Very old mkfs.btrfs (before v4.15) will not respect the reserved
* space. Although kernel can handle it without problem, better to warn
* the users.
*/
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs: fix comment in reserved space warning
2025-04-15 0:25 [PATCH] btrfs: fix comment in reserved space warning Dan Johnson
@ 2025-05-24 17:31 ` Dan Johnson
2025-05-28 23:41 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Dan Johnson @ 2025-05-24 17:31 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba; +Cc: Qu Wenruo, linux-btrfs
Gentle bump here, it looks like this got missed? I did a bunch of
digging to figure that out and wanted to make sure to share it with
others.
On Mon, Apr 14, 2025 at 5:26 PM Dan Johnson <computerdruid@gmail.com> wrote:
>
> mkfs.btrfs up to v4.14 actually can leave a chunk inside the reserved
> space when invoked with `-m single`, fixed by 997f9977c24397eb6980bb9
> ("mkfs: Prevent temporary system chunk to use space in reserved 1M
> range") released with v4.15.
>
> Signed-off-by: Dan Johnson <ComputerDruid@gmail.com>
> ---
> fs/btrfs/volumes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 4d5c5908300..28521015d01 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -7989,7 +7989,7 @@ static int verify_one_dev_extent(struct btrfs_fs_info *fs_info,
> }
>
> /*
> - * Very old mkfs.btrfs (before v4.1) will not respect the reserved
> + * Very old mkfs.btrfs (before v4.15) will not respect the reserved
> * space. Although kernel can handle it without problem, better to warn
> * the users.
> */
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs: fix comment in reserved space warning
2025-05-24 17:31 ` Dan Johnson
@ 2025-05-28 23:41 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2025-05-28 23:41 UTC (permalink / raw)
To: Dan Johnson
Cc: Chris Mason, Josef Bacik, David Sterba, Qu Wenruo, linux-btrfs
On Sat, May 24, 2025 at 10:31:51AM -0700, Dan Johnson wrote:
> Gentle bump here, it looks like this got missed? I did a bunch of
> digging to figure that out and wanted to make sure to share it with
> others.
Not missed, but the timing near release and start of merge window can
cause delays for patches that are not urgent fixes or such. Patch now
added to for-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-28 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-15 0:25 [PATCH] btrfs: fix comment in reserved space warning Dan Johnson
2025-05-24 17:31 ` Dan Johnson
2025-05-28 23:41 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox