From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: Kyoji Ogasawara <sawara04.o@gmail.com>,
Qu Wenruo <quwenruo.btrfs@gmx.com>,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: Raise nobarrier log level to warn
Date: Mon, 26 May 2025 11:14:28 +0200 [thread overview]
Message-ID: <20250526091428.GA4037@suse.cz> (raw)
In-Reply-To: <af00227c-c301-4311-b570-47f4d404c499@suse.com>
On Sat, May 24, 2025 at 01:18:58PM +0930, Qu Wenruo wrote:
>
>
> 在 2025/5/24 11:51, Kyoji Ogasawara 写道:
> > Thanks for the explanation. I understand the issue with btrfs_parse_param()
> > being triggered multiple times.
> >
> > If I move the log into btrfs_parse_param(), it would currently use
> > btrfs_info_if_set(),
> > resulting in an info level log.
> >
> > Is an info level acceptable for this warning, or would you prefer a
> > warn level log?
>
> I think info level is good enough.
>
> As the main purpose of that message line is still just to show we're
> using barrier or not, the extra "use with care" is just something good
> to have.
>
> Thus no need to go warning IMHO.
Agreed, info level is the right one. Warn messages are for user/admin
attention and some action may be needed. If somebody intentionally sets
the slightly dangerous options then info is to log that and "you get
what you ask for".
next prev parent reply other threads:[~2025-05-26 9:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 3:27 [PATCH 0/2] btrfs: Improve logging for barrier-related operation sawara04.o
2025-05-21 3:27 ` [PATCH 1/2] btrfs: Raise nobarrier log level to warn sawara04.o
2025-05-21 4:13 ` Qu Wenruo
2025-05-24 2:21 ` Kyoji Ogasawara
2025-05-24 3:48 ` Qu Wenruo
2025-05-25 2:32 ` Kyoji Ogasawara
2025-05-25 17:45 ` Kyoji Ogasawara
2025-05-26 4:54 ` Qu Wenruo
2025-05-26 9:21 ` David Sterba
2025-06-11 17:06 ` Kyoji Ogasawara
2025-05-26 9:14 ` David Sterba [this message]
2025-05-21 3:27 ` [PATCH 2/2] btrfs: Fix incorrect log message related barrier sawara04.o
2025-05-21 4:15 ` Qu Wenruo
2025-05-24 2:00 ` Kyoji Ogasawara
2025-05-24 2:09 ` Qu Wenruo
2025-07-21 8:07 ` Kyoji Ogasawara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526091428.GA4037@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=sawara04.o@gmail.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox