[PATCH] btrfs: add root id output for direct IO error messages

[PATCH] btrfs: add root id output for direct IO error messages

[Qu Wenruo]

When debugging a kernel warning caused by generic/475, the error
messages from direct IO lacks the subvolume id, meanwhile th error
messages from buffered IO contains both subvolume id and inode number.

This makes debugging much harder to grasp which inode (and its
subvolume) is causing the problem.

Add the subvolume id for direct IO failure message.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 fs/btrfs/direct-io.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/direct-io.c b/fs/btrfs/direct-io.c
index fe9a4bd7e6e6..983b8cb9f688 100644
--- a/fs/btrfs/direct-io.c
+++ b/fs/btrfs/direct-io.c
@@ -649,8 +649,8 @@ static void btrfs_dio_end_io(struct btrfs_bio *bbio)
 
 	if (bio->bi_status) {
 		btrfs_warn(inode->root->fs_info,
-		"direct IO failed ino %llu op 0x%0x offset %#llx len %u err no %d",
-			   btrfs_ino(inode), bio->bi_opf,
+		"direct IO failed root %llu ino %llu op 0x%0x offset %#llx len %u err no %d",
+			   btrfs_root_id(inode->root), btrfs_ino(inode), bio->bi_opf,
 			   dip->file_offset, dip->bytes, bio->bi_status);
 	}
 
-- 
2.49.0

Re: [PATCH] btrfs: add root id output for direct IO error messages

[Daniel Vacek]

On Tue, 20 May 2025 at 01:00, Qu Wenruo <wqu@suse.com> wrote:
>
> When debugging a kernel warning caused by generic/475, the error
> messages from direct IO lacks the subvolume id, meanwhile th error
> messages from buffered IO contains both subvolume id and inode number.
>
> This makes debugging much harder to grasp which inode (and its
> subvolume) is causing the problem.
>
> Add the subvolume id for direct IO failure message.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: Daniel Vacek <neelx@suse.com>


> ---
>  fs/btrfs/direct-io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/direct-io.c b/fs/btrfs/direct-io.c
> index fe9a4bd7e6e6..983b8cb9f688 100644
> --- a/fs/btrfs/direct-io.c
> +++ b/fs/btrfs/direct-io.c
> @@ -649,8 +649,8 @@ static void btrfs_dio_end_io(struct btrfs_bio *bbio)
>
>         if (bio->bi_status) {
>                 btrfs_warn(inode->root->fs_info,
> -               "direct IO failed ino %llu op 0x%0x offset %#llx len %u err no %d",
> -                          btrfs_ino(inode), bio->bi_opf,
> +               "direct IO failed root %llu ino %llu op 0x%0x offset %#llx len %u err no %d",
> +                          btrfs_root_id(inode->root), btrfs_ino(inode), bio->bi_opf,
>                            dip->file_offset, dip->bytes, bio->bi_status);
>         }
>
> --
> 2.49.0
>
>

Re: [PATCH] btrfs: add root id output for direct IO error messages

[David Sterba]

On Tue, May 20, 2025 at 08:30:32AM +0930, Qu Wenruo wrote:
> When debugging a kernel warning caused by generic/475, the error
> messages from direct IO lacks the subvolume id, meanwhile th error
> messages from buffered IO contains both subvolume id and inode number.
> 
> This makes debugging much harder to grasp which inode (and its
> subvolume) is causing the problem.
> 
> Add the subvolume id for direct IO failure message.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: David Sterba <dsterba@suse.com>