Re: [PATCH v2 1/6] btrfs-progs: introduce "btrfs rescue fix-data-checksum"

[David Sterba <dsterba@suse.cz>]

On Thu, May 15, 2025 at 05:30:16PM +0930, Qu Wenruo wrote:
> +static void report_corrupted_blocks(void)
> +{
> +	struct corrupted_block *entry;
> +
> +	if (list_empty(&corrupted_blocks)) {
> +		printf("No data checksum mismatch found\n");

printf(...) -> pr_verbose(LOG_DEFAULT, ...) so the verbosity options are
respected. The semantics is the same as printf, so there's no implicit "\n"
and you can glue the lines as you need.

> +		return;
> +	}
> +
> +	list_for_each_entry(entry, &corrupted_blocks, list) {
> +		bool has_printed = false;
> +
> +		printf("logical=%llu corrtuped mirrors=", entry->logical);
> +		/* Poor man's bitmap print. */
> +		for (int i = 0; i < entry->num_mirrors; i++) {
> +			if (test_bit(i, entry->error_mirror_bitmap)) {
> +				if (has_printed)
> +					printf(",");
> +				/*
> +				 * Bit 0 means mirror 1, thus we need to increase
> +				 * the value by 1.
> +				 */
> +				printf("%d", i + 1);
> +				has_printed=true;
> +			}
> +		}
> +		printf("\n");
> +	}
> +}

> +static int cmd_rescue_fix_data_checksum(const struct cmd_struct *cmd,
> +					int argc, char **argv)
> +{
> +	enum btrfs_fix_data_checksum_mode mode = BTRFS_FIX_DATA_CSUMS_READONLY;
> +	int ret;
> +	optind = 0;
> +
> +	while (1) {
> +		int c;
> +		enum { GETOPT_VAL_DRYRUN = GETOPT_VAL_FIRST, };

The ending "," does not need to be there

> +		static const struct option long_options [] = {
> +			{"readonly", no_argument, NULL, 'r'},
> +			{"NULL", 0, NULL, 0},
> +		};

Missing newline

> +		c = getopt_long(argc, argv, "r", long_options, NULL);
> +		if (c < 0)
> +			break;
> +		switch (c) {
> +		case 'r':
> +			mode = BTRFS_FIX_DATA_CSUMS_READONLY;
> +			break;
> +		default:
> +			usage_unknown_option(cmd, argv);
> +		}
> +	}
> +	if (check_argc_min(argc - optind, 1))
> +		return 1;
> +	ret = btrfs_recover_fix_data_checksum(argv[optind], mode);
> +	if (ret < 0) {
> +		errno = -ret;
> +		error("failed to fix data checksums: %m");
> +	}
> +	return !!ret;
> +}
> +static DEFINE_SIMPLE_COMMAND(rescue_fix_data_checksum, "fix-data-checksum");