Re: [PATCH v2 4/6] btrfs-progs: fix-data-checksum: introduce interactive mode

[David Sterba <dsterba@suse.cz>]

On Thu, May 15, 2025 at 05:30:19PM +0930, Qu Wenruo wrote:
> --- a/cmds/rescue-fix-data-checksum.c
> +++ b/cmds/rescue-fix-data-checksum.c
> @@ -14,6 +14,7 @@
>   * Boston, MA 021110-1307, USA.
>   */
>  
> +#include <ctype.h>
>  #include "kerncompat.h"

The kerncompat.h needs to be first as there are workarounds for some
system includes. This has been unified everywhere else so please stick
to the ordering.

>  #include "kernel-shared/disk-io.h"
>  #include "kernel-shared/ctree.h"
> @@ -45,6 +46,21 @@ struct corrupted_block {
>  	unsigned long *error_mirror_bitmap;
>  };
>  
> +enum fix_data_checksum_action_value {
> +	ACTION_IGNORE,
> +	ACTION_LAST,
> +};
> +
> +static const struct fix_data_checksum_action {
> +	enum fix_data_checksum_action_value value;
> +	const char *string;
> +} actions[] = {
> +	[ACTION_IGNORE] = {
> +		.value = ACTION_IGNORE,
> +		.string = "ignore",
> +	},
> +};
> +
>  static int global_repair_mode;
>  LIST_HEAD(corrupted_blocks);
>  
> @@ -241,10 +257,49 @@ next:
>  	return ret;
>  }
>  
> @@ -277,6 +332,16 @@ static void report_corrupted_blocks(struct btrfs_fs_info *fs_info)
>  			error("failed to iterate involved files: %m");
>  			break;
>  		}
> +		switch (mode) {
> +		case BTRFS_FIX_DATA_CSUMS_INTERACTIVE:
> +			action = ask_action();
> +			UASSERT(action == ACTION_IGNORE);
> +			fallthrough;
> +		case BTRFS_FIX_DATA_CSUMS_READONLY:
> +			break;
> +		default:
> +			UASSERT(0);

I haven't fixed that but please don't do the ASSERT(0), we have
INTERNAL_ERROR for runtime errors or handle it and return with a hard
exit.

> +		}
>  	}
>  }