From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2] fstests: generic/730: exclude btrfs for now
Date: Wed, 4 Jun 2025 16:40:24 +0930 [thread overview]
Message-ID: <20250604071024.231586-1-wqu@suse.com> (raw)
The test case always fail for btrfs:
generic/730 - output mismatch (see /home/adam/xfstests-dev/results//generic/730.out.bad)
--- tests/generic/730.out 2024-04-25 18:13:45.203549435 +0930
+++ /home/adam/xfstests-dev/results//generic/730.out.bad 2025-06-04 15:10:39.062430952 +0930
@@ -1,2 +1 @@
QA output created by 730
-cat: -: Input/output error
...
The root reason is that, btrfs doesn't implement its blk_holder_ops when
opening a block device.
Thus when the underlying block device is marked dead, btrfs is never
going to know thus no way to shutdown (nor btrfs has a way to shutdown
either).
I'm trying to improve the situation, but until then just exlucde btrfs
from the test case for now.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
Changelog:
v2:
- Update the root reason
It's not the sb->s_op->shutdown, that is only for single device
fs (through fs_bdev_mark_dead()).
For a multi-devices fs, it should provide a blk_holder_ops when
opening the block device.
---
tests/generic/730 | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/generic/730 b/tests/generic/730
index 6251980e..cae6489f 100755
--- a/tests/generic/730
+++ b/tests/generic/730
@@ -26,6 +26,10 @@ _require_test
_require_block_device $TEST_DEV
_require_scsi_debug
+if [ "$FSTYP" = "btrfs" ]; then
+ _notrun "btrfs doesn't support per-fs shutdown yet"
+fi
+
size=$(_small_fs_size_mb 256)
SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size`
test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device"
--
2.49.0
next reply other threads:[~2025-06-04 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 7:10 Qu Wenruo [this message]
2025-06-04 8:10 ` [PATCH v2] fstests: generic/730: exclude btrfs for now Anand Jain
2025-06-04 9:13 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604071024.231586-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox