Re: [PATCH v2] fstests: generic/730: exclude btrfs for now

[Anand Jain <anand.jain@oracle.com>]

On 6/4/2025 3:10 PM, Qu Wenruo wrote:
> The test case always fail for btrfs:
> 
>    generic/730       - output mismatch (see /home/adam/xfstests-dev/results//generic/730.out.bad)
>      --- tests/generic/730.out	2024-04-25 18:13:45.203549435 +0930
>      +++ /home/adam/xfstests-dev/results//generic/730.out.bad	2025-06-04 15:10:39.062430952 +0930
>      @@ -1,2 +1 @@
>       QA output created by 730
>      -cat: -: Input/output error
>      ...



[PATCH v1 5/7] generic/730: add _require_scratch_shutdown

Fixed it.


> 
> The root reason is that, btrfs doesn't implement its blk_holder_ops when
> opening a block device.
> Thus when the underlying block device is marked dead, btrfs is never
> going to know thus no way to shutdown (nor btrfs has a way to shutdown
> either).
> 
> I'm trying to improve the situation, but until then just exlucde btrfs
> from the test case for now.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> Changelog:
> v2:
> - Update the root reason
>    It's not the sb->s_op->shutdown, that is only for single device
>    fs (through fs_bdev_mark_dead()).
>    For a multi-devices fs, it should provide a blk_holder_ops when
>    opening the block device.

Along with that, I think it is a good idea to bring  XFS_IOC_GOINGDOWN, 
per fs (all devices in a multi-device fs) and vfs level so that we could 
support unmount --force.

>   
> +if [ "$FSTYP" = "btrfs" ]; then
> +	_notrun "btrfs doesn't support per-fs shutdown yet"
> +fi
> +

_require_scratch_shutdown() will take care.


Thanks, Anand