From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v6 0/8] btrfs: use fs_holder_ops for btrfs
Date: Tue, 1 Jul 2025 16:38:42 +0200 [thread overview]
Message-ID: <20250701143842.GP31241@twin.jikos.cz> (raw)
In-Reply-To: <cover.1751261286.git.wqu@suse.com>
On Mon, Jun 30, 2025 at 02:59:04PM +0930, Qu Wenruo wrote:
> [CHANGELOG]
> v6:
> - Fix an error handling bug that can lead to use-after-free
> Reported by syzbot, that inside btrfs_get_tree_super() that if we
> didn't open the devices, there are corner cases that
> fs_info->fs_devices can be freed twice, causing use-after-free bug.
>
> This one fixed two error paths:
> * sget_fc() failure
> Which is not the one reported by syzbot, but still possible to hit.
>
> * btrfs_open_devices() failure
> Which I believe is the one reported by syzbot.
>
> There is a dedicated fix pushed into linux-next.
>
> This refreshed series is for the proper merge into our for-next
> branch.
Updated in linux-next. There were some conflicts between branches so
this got a bit delayed. If there are no significant problems found,
please add the branch to for-next by Friday or on Monday at the latest.
Thanks.
prev parent reply other threads:[~2025-07-01 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 5:29 [PATCH v6 0/8] btrfs: use fs_holder_ops for btrfs Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 1/8] btrfs: always open the device read-only in btrfs_scan_one_device Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 2/8] btrfs: get rid of the re-entry of btrfs_get_tree() Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 3/8] btrfs: add comments to make super block creation more clear Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 4/8] btrfs: call btrfs_close_devices from ->kill_sb Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 5/8] btrfs: call bdev_fput() to reclaim the blk_holder immediately Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 6/8] btrfs: delay btrfs_open_devices() until super block is created Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 7/8] btrfs: use the super_block as holder when mounting file systems Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 8/8] btrfs: use fs_holder_ops for all opened devices Qu Wenruo
2025-06-30 5:40 ` [PATCH v6 0/8] btrfs: use fs_holder_ops for btrfs Christoph Hellwig
2025-06-30 5:43 ` Qu Wenruo
2025-06-30 5:49 ` Christoph Hellwig
2025-07-01 14:38 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701143842.GP31241@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox