From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v6 0/8] btrfs: use fs_holder_ops for btrfs
Date: Sun, 29 Jun 2025 22:49:28 -0700 [thread overview]
Message-ID: <aGIlaA3wxb6b7Ea7@infradead.org> (raw)
In-Reply-To: <2ddf32ff-7411-4325-9ce2-116f4c5f6362@suse.com>
On Mon, Jun 30, 2025 at 03:13:11PM +0930, Qu Wenruo wrote:
>
>
> 在 2025/6/30 15:10, Christoph Hellwig 写道:
> > Looks like this doesn't add the remove_dev method and thus does the
> > wrong thing when a device underlying a raid configuration gets removed?
> >
>
> The remove_bdev() callback is a completely different patchset, which depends
> on the btrfs shutdown support.
>
> This series is only for the blk_holder_ops, and will be the basis for the
> remove_bdev() series.
Oh, right. Without ->shutdown we're not getting any shutdown at all
so things should be fine. Sorry for the noise.
next prev parent reply other threads:[~2025-06-30 5:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 5:29 [PATCH v6 0/8] btrfs: use fs_holder_ops for btrfs Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 1/8] btrfs: always open the device read-only in btrfs_scan_one_device Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 2/8] btrfs: get rid of the re-entry of btrfs_get_tree() Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 3/8] btrfs: add comments to make super block creation more clear Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 4/8] btrfs: call btrfs_close_devices from ->kill_sb Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 5/8] btrfs: call bdev_fput() to reclaim the blk_holder immediately Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 6/8] btrfs: delay btrfs_open_devices() until super block is created Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 7/8] btrfs: use the super_block as holder when mounting file systems Qu Wenruo
2025-06-30 5:29 ` [PATCH v6 8/8] btrfs: use fs_holder_ops for all opened devices Qu Wenruo
2025-06-30 5:40 ` [PATCH v6 0/8] btrfs: use fs_holder_ops for btrfs Christoph Hellwig
2025-06-30 5:43 ` Qu Wenruo
2025-06-30 5:49 ` Christoph Hellwig [this message]
2025-07-01 14:38 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGIlaA3wxb6b7Ea7@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox