From: Boris Burkov <boris@bur.io>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs-progs: fsck-tests: make test case 066 to be repairable
Date: Wed, 19 Nov 2025 15:03:49 -0800 [thread overview]
Message-ID: <20251119230349.GC2475306@zen.localdomain> (raw)
In-Reply-To: <59b21f15f2199cd27233c367457935cb2708e63f.1763156743.git.wqu@suse.com>
On Sat, Nov 15, 2025 at 08:16:00AM +1030, Qu Wenruo wrote:
> The test case fsck/066 is only to verify we can detect the missing root
> orphan item, no repair for it yet.
>
> Now the repair ability is added, change the test case to verify the
> repair is also properly done.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Boris Burkov <boris@bur.io>
> ---
> .../.lowmem_repairable | 0
> .../066-missing-root-orphan-item/test.sh | 14 --------------
> 2 files changed, 14 deletions(-)
> create mode 100644 tests/fsck-tests/066-missing-root-orphan-item/.lowmem_repairable
> delete mode 100755 tests/fsck-tests/066-missing-root-orphan-item/test.sh
>
> diff --git a/tests/fsck-tests/066-missing-root-orphan-item/.lowmem_repairable b/tests/fsck-tests/066-missing-root-orphan-item/.lowmem_repairable
> new file mode 100644
> index 000000000000..e69de29bb2d1
> diff --git a/tests/fsck-tests/066-missing-root-orphan-item/test.sh b/tests/fsck-tests/066-missing-root-orphan-item/test.sh
> deleted file mode 100755
> index 9db625714c1f..000000000000
> --- a/tests/fsck-tests/066-missing-root-orphan-item/test.sh
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -#!/bin/bash
> -#
> -# Verify that check can report missing orphan root itemm as an error
> -
> -source "$TEST_TOP/common" || exit
> -
> -check_prereq btrfs
> -
> -check_image() {
> - run_mustfail "missing root orphan item not reported as an error" \
> - "$TOP/btrfs" check "$1"
> -}
> -
> -check_all_images
> --
> 2.51.2
>
prev parent reply other threads:[~2025-11-19 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 21:45 [PATCH 0/2] btrfs-progs: check: add repair ability for missing root orphan item Qu Wenruo
2025-11-14 21:45 ` [PATCH 1/2] btrfs-progs: check: add repair ability for missing orphan root item Qu Wenruo
2025-11-19 23:02 ` Boris Burkov
2025-11-14 21:46 ` [PATCH 2/2] btrfs-progs: fsck-tests: make test case 066 to be repairable Qu Wenruo
[not found] ` <314461b6-9c30-4f19-aed3-486656db661e@libero.it>
2025-11-15 10:45 ` Qu Wenruo
2025-11-19 23:03 ` Boris Burkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119230349.GC2475306@zen.localdomain \
--to=boris@bur.io \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox