Re: [PATCH 2/2] btrfs-progs: fsck-tests: make test case 066 to be repairable

[Qu Wenruo <wqu@suse.com>]

在 2025/11/15 20:17, Goffredo Baroncelli 写道:
> On 14/11/2025 22.46, Qu Wenruo wrote:
>> The test case fsck/066 is only to verify we can detect the missing root
>> orphan item, no repair for it yet.
>>
>> Now the repair ability is added, change the test case to verify the
>> repair is also properly done.
> 
> 
> It seems more that this patch only can removed a test...
> 
> May be something was wrong ?

Nope, it's completely correct.

Check run_one_test() from tests/fsck-tests.sh.

There are tons of examples inside tests/fsck-tests/ where there are only 
test images without test.sh.

Test.sh are all utilized to override the existing check_image() which is 
not the full default check-repair-check run.

Thanks,
Qu
> 
> 
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>> ---
>>   .../.lowmem_repairable                             |  0
>>   .../066-missing-root-orphan-item/test.sh           | 14 --------------
>>   2 files changed, 14 deletions(-)
>>   create mode 100644 tests/fsck-tests/066-missing-root-orphan- 
>> item/.lowmem_repairable
>>   delete mode 100755 tests/fsck-tests/066-missing-root-orphan-item/ 
>> test.sh
>>
>> diff --git a/tests/fsck-tests/066-missing-root-orphan- 
>> item/.lowmem_repairable b/tests/fsck-tests/066-missing-root-orphan- 
>> item/.lowmem_repairable
>> new file mode 100644
>> index 000000000000..e69de29bb2d1
>> diff --git a/tests/fsck-tests/066-missing-root-orphan-item/test.sh b/ 
>> tests/fsck-tests/066-missing-root-orphan-item/test.sh
>> deleted file mode 100755
>> index 9db625714c1f..000000000000
>> --- a/tests/fsck-tests/066-missing-root-orphan-item/test.sh
>> +++ /dev/null
>> @@ -1,14 +0,0 @@
>> -#!/bin/bash
>> -#
>> -# Verify that check can report missing orphan root itemm as an error
>> -
>> -source "$TEST_TOP/common" || exit
>> -
>> -check_prereq btrfs
>> -
>> -check_image() {
>> -    run_mustfail "missing root orphan item not reported as an error" \
>> -        "$TOP/btrfs" check "$1"
>> -}
>> -
>> -check_all_images
> 
>