From: Zhen Ni <zhen.ni@easystack.cn>
To: clm@fb.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, Zhen Ni <zhen.ni@easystack.cn>
Subject: [PATCH] btrfs: remove redundant inode NULL check in is_data_bbio()
Date: Fri, 19 Dec 2025 16:43:16 +0800 [thread overview]
Message-ID: <20251219084316.1164580-1-zhen.ni@easystack.cn> (raw)
After commit 81cea6cd7041 ("btrfs: remove btrfs_bio::fs_info by
extracting it from btrfs_bio::inode"), the btrfs_bio::inode field is
mandatory for all btrfs_bio allocations. The NULL check is redundant and
can be removed.
Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
---
fs/btrfs/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c
index fa1d321a2fb8..ce649e265b75 100644
--- a/fs/btrfs/bio.c
+++ b/fs/btrfs/bio.c
@@ -29,7 +29,7 @@ struct btrfs_failed_bio {
/* Is this a data path I/O that needs storage layer checksum and repair? */
static inline bool is_data_bbio(const struct btrfs_bio *bbio)
{
- return bbio->inode && is_data_inode(bbio->inode);
+ return is_data_inode(bbio->inode);
}
static bool bbio_has_ordered_extent(const struct btrfs_bio *bbio)
--
2.20.1
next reply other threads:[~2025-12-19 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 8:43 Zhen Ni [this message]
2025-12-19 12:56 ` [PATCH] btrfs: remove redundant inode NULL check in is_data_bbio() Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219084316.1164580-1-zhen.ni@easystack.cn \
--to=zhen.ni@easystack.cn \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox