[PATCH] btrfs: remove redundant inode NULL check in is_data_bbio()

[PATCH] btrfs: remove redundant inode NULL check in is_data_bbio()

[Zhen Ni]

After commit 81cea6cd7041 ("btrfs: remove btrfs_bio::fs_info by
extracting it from btrfs_bio::inode"), the btrfs_bio::inode field is
mandatory for all btrfs_bio allocations. The NULL check is redundant and
can be removed.

Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
---
 fs/btrfs/bio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c
index fa1d321a2fb8..ce649e265b75 100644
--- a/fs/btrfs/bio.c
+++ b/fs/btrfs/bio.c
@@ -29,7 +29,7 @@ struct btrfs_failed_bio {
 /* Is this a data path I/O that needs storage layer checksum and repair? */
 static inline bool is_data_bbio(const struct btrfs_bio *bbio)
 {
-	return bbio->inode && is_data_inode(bbio->inode);
+	return is_data_inode(bbio->inode);
 }
 
 static bool bbio_has_ordered_extent(const struct btrfs_bio *bbio)
-- 
2.20.1

Re: [PATCH] btrfs: remove redundant inode NULL check in is_data_bbio()

[Johannes Thumshirn]

On 12/19/25 9:43 AM, Zhen Ni wrote:
> After commit 81cea6cd7041 ("btrfs: remove btrfs_bio::fs_info by
> extracting it from btrfs_bio::inode"), the btrfs_bio::inode field is
> mandatory for all btrfs_bio allocations. The NULL check is redundant and
> can be removed.
>
> Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
> ---
>   fs/btrfs/bio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c
> index fa1d321a2fb8..ce649e265b75 100644
> --- a/fs/btrfs/bio.c
> +++ b/fs/btrfs/bio.c
> @@ -29,7 +29,7 @@ struct btrfs_failed_bio {
>   /* Is this a data path I/O that needs storage layer checksum and repair? */
>   static inline bool is_datais_data_bbio
> _bbio(const struct btrfs_bio *bbio)
>   {
> -	return bbio->inode && is_data_inode(bbio->inode);
> +	return is_data_inode(bbio->inode);
>   }
>   
>   static bool bbio_has_ordered_extent(const struct btrfs_bio *bbio)

But then is_data_bbio() becomes a simple wrapper around is_data_inode() 
not adding any functionality or documentation. I'd think you scan just 
replace is_data_bbio(bbio) with is_data_inode(bbio->inode) in all of bio.c