btrfs ASSERT() error when make C=1, but OK when make C=0

btrfs ASSERT() error when make C=1, but OK when make C=0

[Wang Yugui]

Hi,

I noticed a lot of make C=1 error of btrfs ASSERT(),
but make C=0 is OK.

block-group.c: note: in included file:
zoned.h:417:9: error: Expected ) in function call
zoned.h:417:9: error: got __VA_OPT__

static inline bool btrfs_zoned_bg_is_full(const struct btrfs_block_group *bg)
{
L417:    ASSERT(btrfs_is_zoned(bg->fs_info));
    return (bg->alloc_offset == bg->zone_capacity);
}

Any help to fix it?

Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2025/12/22

Re: btrfs ASSERT() error when make C=1, but OK when make C=0

[Qu Wenruo]

在 2025/12/23 01:07, Wang Yugui 写道:
> Hi,
> 
> I noticed a lot of make C=1 error of btrfs ASSERT(),
> but make C=0 is OK.
> 
> block-group.c: note: in included file:
> zoned.h:417:9: error: Expected ) in function call
> zoned.h:417:9: error: got __VA_OPT__

You know this is from sparse right?

And sparse is known to cause false positive.

> 
> static inline bool btrfs_zoned_bg_is_full(const struct btrfs_block_group *bg)
> {
> L417:    ASSERT(btrfs_is_zoned(bg->fs_info));
>      return (bg->alloc_offset == bg->zone_capacity);
> }
> 
> Any help to fix it?

Then why don't you dig it deeper?
You are an employed developer, not some newbie.

Do your work, not off load it to others.

> 
> Best Regards
> Wang Yugui (wangyugui@e16-tech.com)
> 2025/12/22
> 
> 
> 

Re: btrfs ASSERT() error when make C=1, but OK when make C=0

[Wang Yugui]

Hi

> Hi,
> 
> I noticed a lot of make C=1 error of btrfs ASSERT(),
> but make C=0 is OK.
> 
> block-group.c: note: in included file:
> zoned.h:417:9: error: Expected ) in function call
> zoned.h:417:9: error: got __VA_OPT__
> 
> static inline bool btrfs_zoned_bg_is_full(const struct btrfs_block_group *bg)
> {
> L417:    ASSERT(btrfs_is_zoned(bg->fs_info));
>     return (bg->alloc_offset == bg->zone_capacity);
> }
> 
> Any help to fix it?

We can walk around this problem with the flowing patch.
It seems that sparse(make C=1) does yet not support __VA_OPT__.

diff --git a/fs/btrfs/messages.h b/fs/btrfs/messages.h
index dea30823d61a..8755a5bc7ece 100644
--- a/fs/btrfs/messages.h
+++ b/fs/btrfs/messages.h
@@ -111,7 +111,7 @@ static inline void verify_assert_printk_format(const char *fmt, ...) {
  * As ##__VA_ARGS__ cannot be at the beginning of the macro the __VA_OPT__ is needed
  * and supported since GCC 8 and Clang 12.
  */
-#define __REST_ARGS(_, ... ) __VA_OPT__(,) __VA_ARGS__
+#define __REST_ARGS(_, ... ) , ##__VA_ARGS__
 
 #if defined(CONFIG_CC_IS_CLANG) || GCC_VERSION >= 80000
 /*


Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2025/12/25