[PATCH] fsx: add missing -T option to getopt_long()

[PATCH] fsx: add missing -T option to getopt_long()

[fdmanana]

From: Filipe Manana <fdmanana@suse.com>

Currently fsx fails with an invalid argument error when we pass the -T
option (do not use dontcache IO) to it because it's not listed in the
gepopt_long() call.

Fix this and add T to the getopt_long() call.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 ltp/fsx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ltp/fsx.c b/ltp/fsx.c
index 626976dd..8626662b 100644
--- a/ltp/fsx.c
+++ b/ltp/fsx.c
@@ -3160,7 +3160,7 @@ main(int argc, char **argv)
 	setvbuf(stdout, (char *)0, _IOLBF, 0); /* line buffered stdout */
 
 	while ((ch = getopt_long(argc, argv,
-				 "0ab:c:de:fg:hi:j:kl:m:no:p:qr:s:t:uw:xyABD:EFJKHzCILN:OP:RS:UWXZ",
+				 "0ab:c:de:fg:hi:j:kl:m:no:p:qr:s:t:uw:xyABD:EFJKHzCILN:TOP:RS:UWXZ",
 				 longopts, NULL)) != EOF)
 		switch (ch) {
 		case 'a':
-- 
2.47.2

Re: [PATCH] fsx: add missing -T option to getopt_long()

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] fsx: add missing -T option to getopt_long()

[Darrick J. Wong]

On Mon, Jan 12, 2026 at 01:44:09PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Currently fsx fails with an invalid argument error when we pass the -T
> option (do not use dontcache IO) to it because it's not listed in the
> gepopt_long() call.
> 
> Fix this and add T to the getopt_long() call.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Oops, I totally didn't notice this omission: :(

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  ltp/fsx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ltp/fsx.c b/ltp/fsx.c
> index 626976dd..8626662b 100644
> --- a/ltp/fsx.c
> +++ b/ltp/fsx.c
> @@ -3160,7 +3160,7 @@ main(int argc, char **argv)
>  	setvbuf(stdout, (char *)0, _IOLBF, 0); /* line buffered stdout */
>  
>  	while ((ch = getopt_long(argc, argv,
> -				 "0ab:c:de:fg:hi:j:kl:m:no:p:qr:s:t:uw:xyABD:EFJKHzCILN:OP:RS:UWXZ",
> +				 "0ab:c:de:fg:hi:j:kl:m:no:p:qr:s:t:uw:xyABD:EFJKHzCILN:TOP:RS:UWXZ",
>  				 longopts, NULL)) != EOF)
>  		switch (ch) {
>  		case 'a':
> -- 
> 2.47.2
> 
> 

Re: [PATCH] fsx: add missing -T option to getopt_long()

[Zorro Lang]

On Mon, Jan 12, 2026 at 01:44:09PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Currently fsx fails with an invalid argument error when we pass the -T
> option (do not use dontcache IO) to it because it's not listed in the
> gepopt_long() call.
> 
> Fix this and add T to the getopt_long() call.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---

Wow, so no one used this option before :) I just tried to search in xfstests,
I didn't find any test cases or common helpers use the -T option of fsx, that's
why we didn't find this issue before. I think you might test with FSX_AVOID="-T"
or run fsx with -T manually. Anyway, thanks for finding and fixing this issue!

Reviewed-by: Zorro Lang <zlang@redhat.com>

Thanks,
Zorro

>  ltp/fsx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ltp/fsx.c b/ltp/fsx.c
> index 626976dd..8626662b 100644
> --- a/ltp/fsx.c
> +++ b/ltp/fsx.c
> @@ -3160,7 +3160,7 @@ main(int argc, char **argv)
>  	setvbuf(stdout, (char *)0, _IOLBF, 0); /* line buffered stdout */
>  
>  	while ((ch = getopt_long(argc, argv,
> -				 "0ab:c:de:fg:hi:j:kl:m:no:p:qr:s:t:uw:xyABD:EFJKHzCILN:OP:RS:UWXZ",
> +				 "0ab:c:de:fg:hi:j:kl:m:no:p:qr:s:t:uw:xyABD:EFJKHzCILN:TOP:RS:UWXZ",
>  				 longopts, NULL)) != EOF)
>  		switch (ch) {
>  		case 'a':
> -- 
> 2.47.2
> 
>