* [PATCH v2] btrfs: Add missing sctx check in cleanup path
@ 2026-07-14 1:28 Hongling Zeng
2026-07-17 19:51 ` Boris Burkov
2026-07-20 10:57 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Hongling Zeng @ 2026-07-14 1:28 UTC (permalink / raw)
To: clm, dsterba
Cc: linux-btrfs, linux-kernel, zhongling0719, Hongling Zeng,
David Sterba
Add sctx NULL check in the for loop condition of the sort_clone_roots
cleanup path for consistency with the else branch
Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
Suggested-by: David Sterba <dsterba@suse.cz>
---
Change in v2:
-Uses the same pattern: for (i = 0; sctx && i < clone_sources_to_rollback; i++)
,suggested by David
---
fs/btrfs/send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 3ae480c7474b..297704edf1b4 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -8251,7 +8251,7 @@ long btrfs_ioctl_send(struct btrfs_root *send_root, const struct btrfs_ioctl_sen
}
if (sort_clone_roots) {
- for (i = 0; i < sctx->clone_roots_cnt; i++) {
+ for (i = 0; sctx && i < sctx->clone_roots_cnt; i++) {
btrfs_root_dec_send_in_progress(
sctx->clone_roots[i].root);
btrfs_put_root(sctx->clone_roots[i].root);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] btrfs: Add missing sctx check in cleanup path
2026-07-14 1:28 [PATCH v2] btrfs: Add missing sctx check in cleanup path Hongling Zeng
@ 2026-07-17 19:51 ` Boris Burkov
2026-07-20 10:57 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Boris Burkov @ 2026-07-17 19:51 UTC (permalink / raw)
To: Hongling Zeng
Cc: clm, dsterba, linux-btrfs, linux-kernel, zhongling0719,
David Sterba
On Tue, Jul 14, 2026 at 09:28:50AM +0800, Hongling Zeng wrote:
> Add sctx NULL check in the for loop condition of the sort_clone_roots
> cleanup path for consistency with the else branch
>
Reviewed-by: Boris Burkov <boris@bur.io>
> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
> Suggested-by: David Sterba <dsterba@suse.cz>
> ---
> Change in v2:
> -Uses the same pattern: for (i = 0; sctx && i < clone_sources_to_rollback; i++)
> ,suggested by David
> ---
> fs/btrfs/send.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index 3ae480c7474b..297704edf1b4 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -8251,7 +8251,7 @@ long btrfs_ioctl_send(struct btrfs_root *send_root, const struct btrfs_ioctl_sen
> }
>
> if (sort_clone_roots) {
> - for (i = 0; i < sctx->clone_roots_cnt; i++) {
> + for (i = 0; sctx && i < sctx->clone_roots_cnt; i++) {
> btrfs_root_dec_send_in_progress(
> sctx->clone_roots[i].root);
> btrfs_put_root(sctx->clone_roots[i].root);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] btrfs: Add missing sctx check in cleanup path
2026-07-14 1:28 [PATCH v2] btrfs: Add missing sctx check in cleanup path Hongling Zeng
2026-07-17 19:51 ` Boris Burkov
@ 2026-07-20 10:57 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2026-07-20 10:57 UTC (permalink / raw)
To: Hongling Zeng
Cc: clm, dsterba, linux-btrfs, linux-kernel, zhongling0719,
David Sterba
On Tue, Jul 14, 2026 at 09:28:50AM +0800, Hongling Zeng wrote:
> Add sctx NULL check in the for loop condition of the sort_clone_roots
> cleanup path for consistency with the else branch
>
> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
> Suggested-by: David Sterba <dsterba@suse.cz>
Added to for-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-20 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14 1:28 [PATCH v2] btrfs: Add missing sctx check in cleanup path Hongling Zeng
2026-07-17 19:51 ` Boris Burkov
2026-07-20 10:57 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox