[PATCH] btrfs/333: require scratch before checking encoded reads

[PATCH] btrfs/333: require scratch before checking encoded reads

[Prabhakar Pujeri]

_require_btrfs_iouring_encoded_read() formats and mounts the scratch
device while checking for encoded-read support.  Without a configured
scratch device, the test therefore fails before reaching its existing
_require_scratch call.

Move _require_scratch before the encoded-read check so the test is skipped
before its first scratch operation.

Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
 tests/btrfs/333 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/btrfs/333 b/tests/btrfs/333
index 6214d7c..9dcdf1c 100755
--- a/tests/btrfs/333
+++ b/tests/btrfs/333
@@ -13,6 +13,7 @@ _begin_fstest auto quick compress rw io_uring ioctl
 
 _require_command src/btrfs_encoded_read
 _require_command src/btrfs_encoded_write
+_require_scratch
 _require_btrfs_iouring_encoded_read
 # Encoded writes are reject for inodes with the NODATASUM flag, so we must skip
 # the test if running with either the nodatasum or nodatacow (which implies
-- 
2.55.0

Re: [PATCH] btrfs/333: require scratch before checking encoded reads

[Darrick J. Wong]

On Mon, Aug 31, 2026 at 10:42:00AM +0000, Prabhakar Pujeri wrote:
> _require_btrfs_iouring_encoded_read() formats and mounts the scratch
> device while checking for encoded-read support.  Without a configured
> scratch device, the test therefore fails before reaching its existing
> _require_scratch call.
> 
> Move _require_scratch before the encoded-read check so the test is skipped
> before its first scratch operation.
> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>

That looks right to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/btrfs/333 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/btrfs/333 b/tests/btrfs/333
> index 6214d7c..9dcdf1c 100755
> --- a/tests/btrfs/333
> +++ b/tests/btrfs/333
> @@ -13,6 +13,7 @@ _begin_fstest auto quick compress rw io_uring ioctl
>  
>  _require_command src/btrfs_encoded_read
>  _require_command src/btrfs_encoded_write
> +_require_scratch
>  _require_btrfs_iouring_encoded_read
>  # Encoded writes are reject for inodes with the NODATASUM flag, so we must skip
>  # the test if running with either the nodatasum or nodatacow (which implies
> -- 
> 2.55.0
> 
> 

Re: [PATCH] btrfs/333: require scratch before checking encoded reads

[Qu Wenruo]

在 2026/8/31 20:12, Prabhakar Pujeri 写道:
> _require_btrfs_iouring_encoded_read() formats and mounts the scratch
> device while checking for encoded-read support.  Without a configured
> scratch device, the test therefore fails before reaching its existing
> _require_scratch call.

In that case it's better to just add _require_scratch to 
_require_btrfs_iouring_encoded_read(), instead of changing every 
possible caller.

BTW, without a scratch device, more than half of the tests will be 
skipped, thus it may not provide much coverage for such runs.

Thanks,
Qu

> 
> Move _require_scratch before the encoded-read check so the test is skipped
> before its first scratch operation.
> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
>   tests/btrfs/333 | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/btrfs/333 b/tests/btrfs/333
> index 6214d7c..9dcdf1c 100755
> --- a/tests/btrfs/333
> +++ b/tests/btrfs/333
> @@ -13,6 +13,7 @@ _begin_fstest auto quick compress rw io_uring ioctl
>   
>   _require_command src/btrfs_encoded_read
>   _require_command src/btrfs_encoded_write
> +_require_scratch
>   _require_btrfs_iouring_encoded_read
>   # Encoded writes are reject for inodes with the NODATASUM flag, so we must skip
>   # the test if running with either the nodatasum or nodatacow (which implies