From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Rik van Riel <riel@surriel.com>,
Matthew Wilcox <willy@infradead.org>,
Pedro Falcato <pfalcato@suse.de>, Christoph Hellwig <hch@lst.de>,
Jann Horn <jannh@google.com>, David Howells <dhowells@redhat.com>,
John Hubbard <jhubbard@nvidia.com>, Jan Kara <jack@suse.cz>,
Qu Wenruo <wqu@suse.com>, "Darrick J. Wong" <djwong@kernel.org>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-xfs@vger.kernel.org
Subject: Re: Removing ->dirty_folio
Date: Tue, 25 Aug 2026 10:21:43 +0200 [thread overview]
Message-ID: <306a6e9f-8090-463e-8b4e-0e039a4e36da@kernel.org> (raw)
In-Reply-To: <b067b26d9d0bc224b5916c7e064277863e7bbc55.camel@surriel.com>
On 8/24/26 21:33, Rik van Riel wrote:
> On Mon, 2026-08-24 at 20:08 +0100, Matthew Wilcox wrote:
>> I think it's time to remove folio_mark_dirty(), ->dirty_folio() and
>> so on.
>>
>> This is not how filesystems want to be informed of folio dirtying.
>>
> This sounds like I should leave the folio_mark_dirty()
> stuff in the get_user_pages() code alone for now, and
> leave the shaving of that yak to another day?
Absolutely. Making it consistent in GUP is a reasonable cleanup, but don't mix
in too many unrelated things into the same patch set.
> In that case, I'll prepare my next version of the
> get_user_pages() series.
I still want to go over it and provide more feedback.
But that won't happen right now (it's surprising how many people miss that we
are in the merge window) and also not next week (traveling).
But there is also no need to rush this, I'm sure we'll get something done for
the next merge window :)
--
Cheers,
David
next prev parent reply other threads:[~2026-08-25 8:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 19:08 Removing ->dirty_folio Matthew Wilcox
2026-08-24 19:25 ` John Hubbard
2026-08-24 19:43 ` Matthew Wilcox
2026-08-24 19:51 ` John Hubbard
2026-08-24 21:05 ` Matthew Wilcox
2026-08-25 7:59 ` Pedro Falcato
2026-08-24 19:33 ` Rik van Riel
2026-08-25 8:21 ` David Hildenbrand (Arm) [this message]
2026-08-24 21:27 ` Boris Burkov
2026-08-25 19:47 ` Matthew Wilcox
2026-08-24 22:38 ` Qu Wenruo
2026-08-25 19:26 ` Matthew Wilcox
2026-08-25 22:33 ` Qu Wenruo
2026-08-26 4:53 ` Christoph Hellwig
2026-08-26 8:01 ` Christoph Hellwig
2026-08-25 6:48 ` David Howells
2026-08-25 19:16 ` Matthew Wilcox
2026-08-25 7:39 ` Christoph Hellwig
2026-08-25 19:14 ` Matthew Wilcox
2026-08-25 8:25 ` Pedro Falcato
2026-08-25 18:35 ` Matthew Wilcox
2026-08-25 19:35 ` Jann Horn
2026-08-25 19:54 ` Matthew Wilcox
2026-08-25 20:06 ` Jann Horn
2026-08-26 0:02 ` Matthew Wilcox
2026-08-26 5:07 ` Christoph Hellwig
2026-08-26 7:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=306a6e9f-8090-463e-8b4e-0e039a4e36da@kernel.org \
--to=david@kernel.org \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=willy@infradead.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox