From: Sun YangKai <sunk67188@gmail.com>
To: frank.li@vivo.com
Cc: clm@fb.com, dsterba@suse.com, josef@toxicpanda.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
neelx@suse.com
Subject: Re: [PATCH 1/3] btrfs: get rid of path allocation in btrfs_del_inode_extref()
Date: Tue, 15 Apr 2025 22:45:06 +0800 [thread overview]
Message-ID: <3353953.aeNJFYEL58@saltykitkat> (raw)
In-Reply-To: <20250415033854.848776-1-frank.li@vivo.com>
It seems a nice try to reduce path allocation and improve performance.
But it also seems make the code less maintainable. I would prefer to have a
comment saying something like the @path argument is just for reuse the
btrfs_path allocation and only a released or empty btrfs_path should be used
here.
Also, although the path passed is released, it seems the bit flags are still
passed, which makes the behavior of the functions a little different. But it
seems fine since those bit flags are never set in this code path.
next prev parent reply other threads:[~2025-04-15 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 3:38 [PATCH 1/3] btrfs: get rid of path allocation in btrfs_del_inode_extref() Yangtao Li
2025-04-15 3:38 ` [PATCH 2/3] btrfs: get rid of path allocation in btrfs_insert_inode_extref() Yangtao Li
2025-04-15 3:38 ` [PATCH 3/3] btrfs: use BTRFS_PATH_AUTO_FREE in btrfs_truncate_inode_items() Yangtao Li
2025-04-15 14:45 ` Sun YangKai [this message]
2025-04-15 15:56 ` [PATCH 1/3] btrfs: get rid of path allocation in btrfs_del_inode_extref() David Sterba
2025-04-16 13:24 ` 回复: " 李扬韬
2025-04-16 13:37 ` Filipe Manana
2025-04-16 19:11 ` David Sterba
2025-04-16 19:40 ` Filipe Manana
2025-04-17 14:15 ` 回复: " 李扬韬
2025-04-17 14:36 ` Filipe Manana
2025-04-16 19:14 ` 回复: " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3353953.aeNJFYEL58@saltykitkat \
--to=sunk67188@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=frank.li@vivo.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelx@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox