Re: [PATCH] fstests: btrfs/131: remove deprecated v1 space cache tests

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2025/12/25 21:06, Anand Jain 写道:
> 
> 
> On 23/12/25 15:39, Qu Wenruo wrote:
>> Since upstream kernel commit 1e7bec1f7d65 ("btrfs: emit a warning about
>> space cache v1 being deprecated"), v1 space cache is deprecated and
>> we're considering to remove the support soon.
>>
>> This means soon v1 space cache mount option will no longer be accepted,
>> and the test case will fail due to such change.
>>
>> Update the test case to remove all v1 cache usage, so we only support
>> two cache modes, either nospace_cache or space_cache=v2.
>>
>> This also allows bs < ps btrfs to be tested for this test case which has
>> no v1 space cache from day 1.
> 
> We need testing space_cache=v1 for LTS kernels for its maintenance.
> 
> So why not duplicate this test case: one for kernels that support
> both space_cache=v1 and FST, and another for kernels with FST
> support only? Kernels would then either run or _notrun each test
> case accordingly.

I'm fine with that solution, although it will introduce some duplicated 
code between the two test cases.

> 
>> -mkfs_v1
>> -echo "Disabling free space cache and enabling free space tree"
>> +mkfs_nocache
> 
>> +echo "Clearing free space cache and enabling free space tree"
> 
> The message should be “Clearing no space cache..”. ?

Will be changed to something like "Enabling free space tree on no space 
cache space fs".

Thanks,
Qu

> 
> -Anand
> 
>