From: Anand Jain <anajain.sg@gmail.com>
To: Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: btrfs/131: remove deprecated v1 space cache tests
Date: Thu, 25 Dec 2025 18:36:14 +0800 [thread overview]
Message-ID: <5a733a1e-dbc4-4761-bc85-bc811e8fa195@gmail.com> (raw)
In-Reply-To: <20251223073939.128157-1-wqu@suse.com>
On 23/12/25 15:39, Qu Wenruo wrote:
> Since upstream kernel commit 1e7bec1f7d65 ("btrfs: emit a warning about
> space cache v1 being deprecated"), v1 space cache is deprecated and
> we're considering to remove the support soon.
>
> This means soon v1 space cache mount option will no longer be accepted,
> and the test case will fail due to such change.
>
> Update the test case to remove all v1 cache usage, so we only support
> two cache modes, either nospace_cache or space_cache=v2.
>
> This also allows bs < ps btrfs to be tested for this test case which has
> no v1 space cache from day 1.
We need testing space_cache=v1 for LTS kernels for its maintenance.
So why not duplicate this test case: one for kernels that support
both space_cache=v1 and FST, and another for kernels with FST
support only? Kernels would then either run or _notrun each test
case accordingly.
> -mkfs_v1
> -echo "Disabling free space cache and enabling free space tree"
> +mkfs_nocache
> +echo "Clearing free space cache and enabling free space tree"
The message should be “Clearing no space cache..”. ?
-Anand
next prev parent reply other threads:[~2025-12-25 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 7:39 [PATCH] fstests: btrfs/131: remove deprecated v1 space cache tests Qu Wenruo
2025-12-25 10:36 ` Anand Jain [this message]
2025-12-25 20:20 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a733a1e-dbc4-4761-bc85-bc811e8fa195@gmail.com \
--to=anajain.sg@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox