From: Jeongjun Park <aha310510@gmail.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: clm@fb.com, dsterba@suse.com, josef@toxicpanda.com,
syzbot+a0d1f7e26910be4dc171@syzkaller.appspotmail.com,
fdmanana@suse.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] btrfs: qgroup: fix slab-out-of-bounds in btrfs_qgroup_inherit
Date: Fri, 28 Jun 2024 10:21:47 +0900 [thread overview]
Message-ID: <3C7EC608-7AD1-441E-9781-9135F6C352F7@gmail.com> (raw)
In-Reply-To: <40fbcb1c-e35f-4310-a2d9-9932570cb245@gmx.com>
> 2024. 6. 24. 오후 3:41, Qu Wenruo <quwenruo.btrfs@gmx.com> 작성:
>
>
>> 在 2024/6/24 15:59, Jeongjun Park 写道:
>> While debugging, I also found that a problem
>> occurred in btrfs_qgroup_check_inherit().
>> While debugging, I also found that a problem
>> occurred in btrfs_qgroup_check_inherit().
>>
>> I think out-of-bounds can be prevented
>> more effectively if the inspection logic
>> containing btrfs_qgroup_enabled() is
>> moved a little lower.
>>
>> If possible, we will send you the v2 patch.
>> I think out-of-bounds can be prevented
>> more effectively if the inspection logic
>> containing btrfs_qgroup_enabled() is
>> moved a little lower.
>>
>> I will send you the v2 patch later after work.
>
> Mind to check my v2 patch?
>
> https://lore.kernel.org/linux-btrfs/47d3dd33f637b70f230fa31f98dbf9ff066b58bb.1719207446.git.wqu@suse.com/T/#u
>
> I believe this would be enough to prevent the bug from happening, with
> all the existing checks in-place.
>
> Thanks,
> Qu
Perfact Thanks.
Jeongjun Park
prev parent reply other threads:[~2024-06-28 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 3:07 [PATCH] btrfs: qgroup: fix slab-out-of-bounds in btrfs_qgroup_inherit Jeongjun Park
2024-06-24 5:10 ` Qu Wenruo
2024-06-24 5:40 ` Qu Wenruo
[not found] ` <CAO9qdTEJaM=gEgQJLXuhKnh2jNA2KPyU9b4_kMWn6YNa3CU4SQ@mail.gmail.com>
2024-06-24 6:41 ` Qu Wenruo
2024-06-28 1:21 ` Jeongjun Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C7EC608-7AD1-441E-9781-9135F6C352F7@gmail.com \
--to=aha310510@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=syzbot+a0d1f7e26910be4dc171@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox