Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove duplicate error message when writing super blocks
Date: Thu, 17 Sep 2026 07:07:38 +0930	[thread overview]
Message-ID: <3e48c02e-2448-4aab-ba9f-c19f97cb09ca@gmx.com> (raw)
In-Reply-To: <9621b3d58ea4af3cece1e00894d0241233fdd59b.1789576649.git.fdmanana@suse.com>



在 2026/9/17 02:08, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> If the total error count is greater the maximum allowed number of errors,
> we print exactly the same error message twice. Remove one of the messages.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>   fs/btrfs/disk-io.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 161a7b9bb27a..a8535e309b57 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -4228,8 +4228,6 @@ int write_all_supers(struct btrfs_trans_handle *trans)
>   			total_errors++;
>   	}
>   	if (unlikely(total_errors > max_errors)) {
> -		btrfs_err(fs_info, "%d errors while writing supers",
> -			  total_errors);
>   		mutex_unlock(&fs_info->fs_devices->device_list_mutex);
>   
>   		/* FUA is masked off if unsupported and can't be the reason */


      reply	other threads:[~2026-09-16 21:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 16:38 [PATCH] btrfs: remove duplicate error message when writing super blocks fdmanana
2026-09-16 21:37 ` Qu Wenruo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e48c02e-2448-4aab-ba9f-c19f97cb09ca@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox