* [PATCH] btrfs: remove duplicate error message when writing super blocks
@ 2026-09-16 16:38 fdmanana
2026-09-16 21:37 ` Qu Wenruo
0 siblings, 1 reply; 2+ messages in thread
From: fdmanana @ 2026-09-16 16:38 UTC (permalink / raw)
To: linux-btrfs
From: Filipe Manana <fdmanana@suse.com>
If the total error count is greater the maximum allowed number of errors,
we print exactly the same error message twice. Remove one of the messages.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
fs/btrfs/disk-io.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 161a7b9bb27a..a8535e309b57 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -4228,8 +4228,6 @@ int write_all_supers(struct btrfs_trans_handle *trans)
total_errors++;
}
if (unlikely(total_errors > max_errors)) {
- btrfs_err(fs_info, "%d errors while writing supers",
- total_errors);
mutex_unlock(&fs_info->fs_devices->device_list_mutex);
/* FUA is masked off if unsupported and can't be the reason */
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] btrfs: remove duplicate error message when writing super blocks
2026-09-16 16:38 [PATCH] btrfs: remove duplicate error message when writing super blocks fdmanana
@ 2026-09-16 21:37 ` Qu Wenruo
0 siblings, 0 replies; 2+ messages in thread
From: Qu Wenruo @ 2026-09-16 21:37 UTC (permalink / raw)
To: fdmanana, linux-btrfs
在 2026/9/17 02:08, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> If the total error count is greater the maximum allowed number of errors,
> we print exactly the same error message twice. Remove one of the messages.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/disk-io.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 161a7b9bb27a..a8535e309b57 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -4228,8 +4228,6 @@ int write_all_supers(struct btrfs_trans_handle *trans)
> total_errors++;
> }
> if (unlikely(total_errors > max_errors)) {
> - btrfs_err(fs_info, "%d errors while writing supers",
> - total_errors);
> mutex_unlock(&fs_info->fs_devices->device_list_mutex);
>
> /* FUA is masked off if unsupported and can't be the reason */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-16 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-16 16:38 [PATCH] btrfs: remove duplicate error message when writing super blocks fdmanana
2026-09-16 21:37 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox