From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, fdmanana@kernel.org, dsterba@suse.cz,
nborisov@suse.com, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 3/8] btrfs: Switch to iomap_dio_rw() for dio
Date: Thu, 12 Dec 2019 10:56:48 +0100 [thread overview]
Message-ID: <3f945449-bdd8-e9d7-5db9-5a565b8fc2af@suse.de> (raw)
In-Reply-To: <20191212094940.GC15977@infradead.org>
On 12/12/2019 10:49, Christoph Hellwig wrote:
>> @@ -8230,9 +8228,8 @@ static void btrfs_endio_direct_read(struct bio *bio)
>> kfree(dip);
>>
>> dio_bio->bi_status = err;
>> - dio_end_io(dio_bio);
>> + bio_endio(dio_bio);
>> btrfs_io_bio_free_csum(io_bio);
>> - bio_put(bio);
>
> I'm not a btrfs export, but doesn't this introduce a use after free
> as bio_endio also frees io_bio?
No that's ok, as the bio_endio() frees the dio_bio, while
btrfs_io_bio_free_csum() frees the csum of the io_bio (which is a struct
btrfs_io_bio).
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-12-12 9:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 0:30 [PATCH 0/8 v5] btrfs direct-io using iomap Goldwyn Rodrigues
2019-12-12 0:30 ` [PATCH 1/8] fs: Export generic_file_buffered_read() Goldwyn Rodrigues
2019-12-12 9:46 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 2/8] iomap: add a filesystem hook for direct I/O bio submission Goldwyn Rodrigues
2019-12-12 9:47 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 3/8] btrfs: Switch to iomap_dio_rw() for dio Goldwyn Rodrigues
2019-12-12 9:49 ` Christoph Hellwig
2019-12-12 9:56 ` Johannes Thumshirn [this message]
2019-12-12 9:57 ` Christoph Hellwig
2019-12-12 10:38 ` Johannes Thumshirn
2019-12-12 19:42 ` Goldwyn Rodrigues
2019-12-12 0:30 ` [PATCH 4/8] iomap: Move lockdep_assert_held() to iomap_dio_rw() calls Goldwyn Rodrigues
2019-12-12 9:50 ` Christoph Hellwig
2019-12-12 22:24 ` Goldwyn Rodrigues
2019-12-12 22:46 ` Dave Chinner
2019-12-12 0:30 ` [PATCH 5/8] fs: Remove dio_end_io() Goldwyn Rodrigues
2019-12-12 9:50 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 6/8] btrfs: Wait for extent bits to release page Goldwyn Rodrigues
2019-12-12 0:30 ` [PATCH 7/8] btrfs: Use iomap_end() instead of btrfs_dio_data Goldwyn Rodrigues
2019-12-12 9:52 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 8/8] btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK Goldwyn Rodrigues
2019-12-12 8:53 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f945449-bdd8-e9d7-5db9-5a565b8fc2af@suse.de \
--to=jthumshirn@suse.de \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox