From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Zhang Boyang <zhangboyang.id@gmail.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>, Filipe Manana <fdmanana@kernel.org>
Subject: Re: [BUG] two raid consistency bugs
Date: Wed, 15 Jul 2026 19:41:32 +0930 [thread overview]
Message-ID: <4674023f-1b70-4be4-ae0c-c65669901feb@gmx.com> (raw)
In-Reply-To: <ebf9c527-2181-4afe-b88a-4d24fda6d8d9@gmail.com>
在 2026/7/15 19:37, Zhang Boyang 写道:
> Hi,
>
> On 2026/7/15 17:44, Qu Wenruo wrote:
>>> Personally I like the idea of turning metadata trees into merkle
>>> trees (so I wrote it first). But since you are the maintainer, I will
>>> let you decide which way is appropriate.
>>
>> I'm not the maintainer, I just default to not trust ideas/features
>> from unproven contributors, especially when the idea/feature is not
>> simple.
>>
>> Especially considering the increased patches generated by LLMs.
>>
>
> I understand your concern.
>
>>
>> So my suggestion is, if you really want to do long-term contributions,
>> stop coming up with fancy ideas, start from basics like doing proper
>> fstests runs with various combinations, report real bugs and fix
>> simple ones by yourself.
>>
>> Earn your name first then consider fancy ideas.
>>
>
> That's exactly what I'm doing. I'm not requesting devs to fix this bug
> immediately or implement my fancy idea. I wrote two test cases and hope
> it will be helpful to btrfs development. It would be better if these two
> test cases can be merged to test suite.
No, we will not push for test cases without a fix.
There is already a known failure, generic/747, and at least I'm not the
only one regretting pushing that.
>
> I even wrote a draft patch to fix the second bug. However, the first bug
> is not easily solvable. So I had to discuss possible solutions. If
> possible, I would have written a draft patch for the first bug, too.
This is already what I call fancy ideas.
Anyway, this will mostly just get yourself ignored if you really choose
to start from fancy projects.
Those long existing problems are still there for a reason.
If you believe you're smarter than everyone else, then go ahead, no one
is going to make you change your mind.
>
>
> Zhang Boyang
next prev parent reply other threads:[~2026-07-15 10:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 16:10 [BUG] two raid consistency bugs Zhang Boyang
2026-07-14 16:10 ` [PATCH 1/2] fstests: btrfs/348: test ambiguous generation handling on raid1 profile Zhang Boyang
2026-07-14 16:10 ` [PATCH 2/2] fstests: btrfs/349: test if latest tree-log is choosen at mount time " Zhang Boyang
2026-07-14 21:40 ` [BUG] two raid consistency bugs Qu Wenruo
2026-07-15 5:46 ` Zhang Boyang
2026-07-15 6:10 ` Qu Wenruo
2026-07-15 7:38 ` Zhang Boyang
2026-07-15 8:36 ` Qu Wenruo
2026-07-15 9:25 ` Zhang Boyang
2026-07-15 9:44 ` Qu Wenruo
2026-07-15 10:07 ` Zhang Boyang
2026-07-15 10:11 ` Qu Wenruo [this message]
2026-07-15 10:41 ` Zhang Boyang
2026-07-15 13:11 ` Alan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4674023f-1b70-4be4-ae0c-c65669901feb@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
--cc=zhangboyang.id@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox