Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Zhang Boyang <zhangboyang.id@gmail.com>
To: Qu Wenruo <wqu@suse.com>, Qu Wenruo <quwenruo.btrfs@gmx.com>,
	linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>, Filipe Manana <fdmanana@kernel.org>
Subject: Re: [BUG] two raid consistency bugs
Date: Wed, 15 Jul 2026 17:25:18 +0800	[thread overview]
Message-ID: <65a774c8-9019-438f-ab8d-81b458f4f53f@gmail.com> (raw)
In-Reply-To: <8248f43d-d6ab-47e4-9ed9-65bb5c281f4b@suse.com>

Hi,

On 2026/7/15 16:36, Qu Wenruo wrote:

> You're introducing more and more code just to handle some very specific 
> corner cases.
> 
> E.g. for your particular case, you will need a very specific write 
> situation. You're introducing a feature that is very hard to hit under 
> most situations, but we will always bear the burden.
> 

Technically the runtime burden is small because generation mismatch is 
rare. If no generation mismatch is detected, no device will be marked 
dirty and no runtime burden is involved. On the other side, if 
generation mismatch is detected, you always want to run a scrub to 
resync your array.

> I am not even sure if you'll still contribute in the next 5 years, thus 
> I won't bet my 5 cents on that this feature will be properly maintained.
> 
For maintenance burden, yes, there is maintenance burden. So I'm here to 
discuss which way to fix this bug is proper.

> To me, if you really bother this particular situation for whatever 
> reason, just introduce a special harden mount option, that any barrier/ 
> super block write failure will mark the fs error.
> 
> That will be a much safer bet than any of your proposal.

This can be a solution, at the cost of one failing drive will render 
entire raid array unavailable.

Personally I like the idea of turning metadata trees into merkle trees 
(so I wrote it first). But since you are the maintainer, I will let you 
decide which way is appropriate‌.


Zhang Boyang

  reply	other threads:[~2026-07-15  9:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 16:10 [BUG] two raid consistency bugs Zhang Boyang
2026-07-14 16:10 ` [PATCH 1/2] fstests: btrfs/348: test ambiguous generation handling on raid1 profile Zhang Boyang
2026-07-14 16:10 ` [PATCH 2/2] fstests: btrfs/349: test if latest tree-log is choosen at mount time " Zhang Boyang
2026-07-14 21:40 ` [BUG] two raid consistency bugs Qu Wenruo
2026-07-15  5:46   ` Zhang Boyang
2026-07-15  6:10     ` Qu Wenruo
2026-07-15  7:38       ` Zhang Boyang
2026-07-15  8:36         ` Qu Wenruo
2026-07-15  9:25           ` Zhang Boyang [this message]
2026-07-15  9:44             ` Qu Wenruo
2026-07-15 10:07               ` Zhang Boyang
2026-07-15 10:11                 ` Qu Wenruo
2026-07-15 10:41                   ` Zhang Boyang
2026-07-15 13:11                   ` Alan Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65a774c8-9019-438f-ab8d-81b458f4f53f@gmail.com \
    --to=zhangboyang.id@gmail.com \
    --cc=dsterba@suse.com \
    --cc=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox