public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Trager <lt73@cs.drexel.edu>
To: Shen Feng <shen@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs: btrfs file system size should be bigger then 256m
Date: Wed, 31 Dec 2008 02:41:11 -0500	[thread overview]
Message-ID: <495B2217.3030403@cs.drexel.edu> (raw)
In-Reply-To: <495B0D54.7060806@cn.fujitsu.com>

This has been bothering me for some time. Why does btrfs need to have a 
disk greater then 256M? I could see a much smaller limit, say 16M but 
why so much? The file system itself does not need that much space for 
its own use.

Thanks,

Lee

Shen Feng wrote:
> According to btrfs_prepare_device, btrfs file sysstem size
> should be bigger then 256m.
>
> If mkfs.btrfs specifies the file system size samaller then
> that, mkfs.btrfs should report error.
>
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
> ---
>  mkfs.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/mkfs.c b/mkfs.c
> index be93aaa..447e8d7 100644
> --- a/mkfs.c
> +++ b/mkfs.c
> @@ -377,6 +377,10 @@ int main(int ac, char **av)
>  				break;
>  			case 'b':
>  				block_count = parse_size(optarg);
> +				if (block_count < 256*1024*1024) {
> +					fprintf(stderr, "File system size is too small\n");
> +					exit(1);
> +				}
>  				zero_end = 0;
>  				break;
>  			default:
>   


  reply	other threads:[~2008-12-31  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-31  6:12 [PATCH] Btrfs-progs: btrfs file system size should be bigger then 256m Shen Feng
2008-12-31  7:41 ` Lee Trager [this message]
2008-12-31  9:20   ` Shen Feng
2008-12-31 17:49 ` Zach Brown
2009-01-05  1:23   ` Shen Feng
  -- strict thread matches above, loose matches on Subject: below --
2009-01-05 14:44 Tomasz Chmielewski
     [not found] ` <49622525.80001@schleiser.de>
2009-01-05 15:49   ` Tomasz Chmielewski
2009-01-05 16:39     ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495B2217.3030403@cs.drexel.edu \
    --to=lt73@cs.drexel.edu \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=shen@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox