From: Shen Feng <shen@cn.fujitsu.com>
To: Zach Brown <zach.brown@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs: btrfs file system size should be bigger then 256m
Date: Mon, 05 Jan 2009 09:23:48 +0800 [thread overview]
Message-ID: <49616124.2050604@cn.fujitsu.com> (raw)
In-Reply-To: <495BB0AC.5070607@oracle.com>
on 01/01/2009 01:49 AM, Zach Brown wrote:
>> + if (block_count < 256*1024*1024) {
>> + fprintf(stderr, "File system size is too small\n");
>> + exit(1);
>> + }
>
> And please, if you could, include both the size that is too small and
> the size that is required in the message.
>
Thanks. I updated the patch.
Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
---
mkfs.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/mkfs.c b/mkfs.c
index be93aaa..cb21db6 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -377,6 +377,13 @@ int main(int ac, char **av)
break;
case 'b':
block_count = parse_size(optarg);
+ if (block_count < 256*1024*1024) {
+ fprintf(stderr, "File system size "
+ "%llu bytes is too small, "
+ "256M is required at least\n",
+ block_count);
+ exit(1);
+ }
zero_end = 0;
break;
default:
next prev parent reply other threads:[~2009-01-05 1:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 6:12 [PATCH] Btrfs-progs: btrfs file system size should be bigger then 256m Shen Feng
2008-12-31 7:41 ` Lee Trager
2008-12-31 9:20 ` Shen Feng
2008-12-31 17:49 ` Zach Brown
2009-01-05 1:23 ` Shen Feng [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-05 14:44 Tomasz Chmielewski
[not found] ` <49622525.80001@schleiser.de>
2009-01-05 15:49 ` Tomasz Chmielewski
2009-01-05 16:39 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49616124.2050604@cn.fujitsu.com \
--to=shen@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox