From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: Re: [RFC PATCH] btrfs: qgroup: Deprecate the ability to manually inherit rfer/excl numbers
Date: Tue, 19 Dec 2017 13:24:20 +0200 [thread overview]
Message-ID: <4a576fea-4245-702e-01a8-09d5ac359509@suse.com> (raw)
In-Reply-To: <7d8cd1a8-fa0f-7b7a-f06b-ccc714b4e42e@gmx.com>
On 19.12.2017 13:20, Qu Wenruo wrote:
> Naming like pad1/2 will make the check in btrfs_qgroup_inherit() look
> quite weird.
>
> Although I don't have any better idea, so I'm mostly fine with such rename.
Right, I saw the check now, missed it the first time. I think we should
remove it and the code should completely ignore these values. Ideally,
we would have removed them from qgroup_inherit struct as well but this
means breaking the on-disk format. So let's ignore them altogether.
>
> Thanks,
next prev parent reply other threads:[~2017-12-19 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:45 [RFC PATCH] btrfs: qgroup: Deprecate the ability to manually inherit rfer/excl numbers Qu Wenruo
2017-12-19 11:12 ` Nikolay Borisov
2017-12-19 11:20 ` Qu Wenruo
2017-12-19 11:24 ` Nikolay Borisov [this message]
2017-12-19 11:28 ` Qu Wenruo
2017-12-19 19:01 ` Omar Sandoval
2017-12-19 19:19 ` Nikolay Borisov
2017-12-19 19:36 ` Omar Sandoval
2017-12-19 19:44 ` Omar Sandoval
2017-12-20 6:50 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a576fea-4245-702e-01a8-09d5ac359509@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox