From: Omar Sandoval <osandov@osandov.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [RFC PATCH] btrfs: qgroup: Deprecate the ability to manually inherit rfer/excl numbers
Date: Tue, 19 Dec 2017 11:44:55 -0800 [thread overview]
Message-ID: <20171219194455.GC22017@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <20171219193658.GA22017@vader.DHCP.thefacebook.com>
On Tue, Dec 19, 2017 at 11:36:58AM -0800, Omar Sandoval wrote:
> On Tue, Dec 19, 2017 at 09:19:10PM +0200, Nikolay Borisov wrote:
> >
> >
> > On 19.12.2017 21:01, Omar Sandoval wrote:
> > > My only objection is that we shouldn't rename the field names in the
> > > UAPI header. Let's just add a comment that the two counters are ignored.
> > > Besides that,
> >
> > Why is that?
>
> We don't know if anyone is including the UAPI header and referring to
> these fields for whatever reason. A quick Google search doesn't turn up
> anything, but it has been there forever so I think we should err on the
> side of not breaking the API.
At least snapper sets these:
https://github.com/openSUSE/snapper/blob/3c126c92bf2bd25a952800b2efb18754148ac227/snapper/BtrfsUtils.cc#L147
They get it from the libbtrfs header, but we might some day sync it to
the UAPI header. So it's not completely theoretical :)
next prev parent reply other threads:[~2017-12-19 19:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:45 [RFC PATCH] btrfs: qgroup: Deprecate the ability to manually inherit rfer/excl numbers Qu Wenruo
2017-12-19 11:12 ` Nikolay Borisov
2017-12-19 11:20 ` Qu Wenruo
2017-12-19 11:24 ` Nikolay Borisov
2017-12-19 11:28 ` Qu Wenruo
2017-12-19 19:01 ` Omar Sandoval
2017-12-19 19:19 ` Nikolay Borisov
2017-12-19 19:36 ` Omar Sandoval
2017-12-19 19:44 ` Omar Sandoval [this message]
2017-12-20 6:50 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219194455.GC22017@vader.DHCP.thefacebook.com \
--to=osandov@osandov.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox