From: Goffredo Baroncelli <kreijack@gmail.com>
To: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, chris.mason@fusionio.com
Subject: Re: [PATCH] Btrfs-progs: check out if the swap device
Date: Tue, 12 Feb 2013 19:14:24 +0100 [thread overview]
Message-ID: <511A8680.7000400@gmail.com> (raw)
In-Reply-To: <201302120125.AA00019@FM-323941448.jp.fujitsu.com>
On 02/12/2013 02:25 AM, Tsutomu Itoh wrote:
> Currently, the following commands succeed.
>
> # cat /proc/swaps
> Filename Type Size Used Priority
> /dev/sda3 partition 8388604 0 -1
> /dev/sdc8 partition 9765884 0 -2
> # mkfs.btrfs /dev/sdc8
>
> WARNING! - Btrfs v0.20-rc1-165-g82ac345 IS EXPERIMENTAL
> WARNING! - see http://btrfs.wiki.kernel.org before using
>
> fs created label (null) on /dev/sdc8
> nodesize 4096 leafsize 4096 sectorsize 4096 size 9.31GB
> Btrfs v0.20-rc1-165-g82ac345
> # btrfs fi sh /dev/sdc8
> Label: none uuid: fc0bdbd0-7eed-460f-b4e9-131273b66df2
> Total devices 1 FS bytes used 28.00KB
> devid 1 size 9.31GB used 989.62MB path /dev/sdc8
>
> Btrfs v0.20-rc1-165-g82ac345
> #
>
> But we should check out the swap device. So fixed it.
>
> Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
> ---
> (this patch is based on Chris's raid56-experimental branch)
> ---
> mkfs.c | 18 ++++++++++++++++++
> utils.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> utils.h | 1 +
> 3 files changed, 68 insertions(+)
>
> diff --git a/mkfs.c b/mkfs.c
> index 2d3c2af..fdc3373 100644
> --- a/mkfs.c
> +++ b/mkfs.c
> @@ -1366,6 +1366,15 @@ int main(int ac, char **av)
>
> if (source_dir == 0) {
> file = av[optind++];
> + ret = is_swap_device(file);
> + if (ret < 0) {
> + fprintf(stderr, "error checking %s status\n", file);
> + exit(1);
> + }
The fact that it is not possible to perform a check shouldn't prohibit
to run a mkfs.btrfs.
It is possible to add a switch to bypass this kind of checks ? We should
allow the user to be not limited by the fact that the check fails. I am
thinking to a "rescue" scenario like boot in a single mode where not al
filesystem are mounted.
I am referring to all the "safety" check not this one only.
BR
G.Baroncelli
[...]
--
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
prev parent reply other threads:[~2013-02-12 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 1:25 [PATCH] Btrfs-progs: check out if the swap device Tsutomu Itoh
2013-02-12 4:22 ` Eric Sandeen
2013-02-12 5:50 ` Tsutomu Itoh
2013-02-12 17:55 ` Eric Sandeen
2013-02-12 20:57 ` Zach Brown
2013-02-13 4:38 ` Tsutomu Itoh
2013-02-13 21:58 ` Zach Brown
2013-02-14 0:03 ` Tsutomu Itoh
2013-02-14 5:35 ` Zach Brown
2013-02-12 15:06 ` David Sterba
2013-02-12 18:14 ` Goffredo Baroncelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511A8680.7000400@gmail.com \
--to=kreijack@gmail.com \
--cc=chris.mason@fusionio.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=t-itoh@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox