* [PATCH] xfstests: remove recursive include in filter.btrfs
@ 2013-04-21 6:27 Eric Sandeen
2013-04-21 22:49 ` [PATCH V2] " Eric Sandeen
2013-04-22 14:36 ` [PATCH] xfstests: remove recursive " Rich Johnston
0 siblings, 2 replies; 5+ messages in thread
From: Eric Sandeen @ 2013-04-21 6:27 UTC (permalink / raw)
To: xfs-oss, linux-btrfs
Not sure how this happened, but filter.btrfs including
itself leads to immense sadness for any file that includes it.
(I got a segfault when I tried to run 307)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/common/filter.btrfs b/common/filter.btrfs
index b1aa733..99d04a6 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -1,7 +1,5 @@
# Filters for btrfs command output
-. ./common/filter.btrfs
-
# Some, but not all, commands emit "Btrfs <version>"
_filter_btrfs_version()
{
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH V2] xfstests: remove recursive include in filter.btrfs
2013-04-21 6:27 [PATCH] xfstests: remove recursive include in filter.btrfs Eric Sandeen
@ 2013-04-21 22:49 ` Eric Sandeen
2013-04-21 22:51 ` [PATCH V3] xfstests: fix common filter " Eric Sandeen
2013-04-22 14:36 ` [PATCH] xfstests: remove recursive " Rich Johnston
1 sibling, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2013-04-21 22:49 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss, linux-btrfs
Not sure how this happened, but filter.btrfs including
itself leads to immense sadness for any file that includes it.
(I got a segfault when I tried to run 307)
It should be including the common/filter not common/filter.btrfs
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/common/filter.btrfs b/common/filter.btrfs
index b1aa733..3435d8d 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -1,6 +1,6 @@
# Filters for btrfs command output
-. ./common/filter.btrfs
+. ./filter
# Some, but not all, commands emit "Btrfs <version>"
_filter_btrfs_version()
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V3] xfstests: fix common filter include in filter.btrfs
2013-04-21 22:49 ` [PATCH V2] " Eric Sandeen
@ 2013-04-21 22:51 ` Eric Sandeen
2013-04-22 13:45 ` Rich Johnston
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2013-04-21 22:51 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-btrfs, xfs-oss
Not sure how this happened, but filter.btrfs including
itself leads to immense sadness for any file that includes it.
(I got a segfault when I tried to run 307)
It should be including ./common/filter not ./common/filter.btrfs
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
cripes, I'm sorry that took 3 times to get right :/
diff --git a/common/filter.btrfs b/common/filter.btrfs
index b1aa733..e9a2bc2 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -1,6 +1,6 @@
# Filters for btrfs command output
-. ./common/filter.btrfs
+. ./common/filter
# Some, but not all, commands emit "Btrfs <version>"
_filter_btrfs_version()
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V3] xfstests: fix common filter include in filter.btrfs
2013-04-21 22:51 ` [PATCH V3] xfstests: fix common filter " Eric Sandeen
@ 2013-04-22 13:45 ` Rich Johnston
0 siblings, 0 replies; 5+ messages in thread
From: Rich Johnston @ 2013-04-22 13:45 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Eric Sandeen, linux-btrfs, xfs-oss
On 04/21/2013 05:51 PM, Eric Sandeen wrote:
> Not sure how this happened, but filter.btrfs including
> itself leads to immense sadness for any file that includes it.
> (I got a segfault when I tried to run 307)
>
> It should be including ./common/filter not ./common/filter.btrfs
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> cripes, I'm sorry that took 3 times to get right :/
>
Third time is the charm ;) Looks good.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfstests: remove recursive include in filter.btrfs
2013-04-21 6:27 [PATCH] xfstests: remove recursive include in filter.btrfs Eric Sandeen
2013-04-21 22:49 ` [PATCH V2] " Eric Sandeen
@ 2013-04-22 14:36 ` Rich Johnston
1 sibling, 0 replies; 5+ messages in thread
From: Rich Johnston @ 2013-04-22 14:36 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss, linux-btrfs
Thanks for the patch Eric, V3 has been committed.
--Rich
commit e771c54c45a5c475bedbc5a2d6becc05be940dba
Author: Eric Sandeen <sandeen@sandeen.net>
Date: Sun Apr 21 22:51:54 2013 +0000
xfstests: fix common filter include in filter.btrfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-22 14:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-21 6:27 [PATCH] xfstests: remove recursive include in filter.btrfs Eric Sandeen
2013-04-21 22:49 ` [PATCH V2] " Eric Sandeen
2013-04-21 22:51 ` [PATCH V3] xfstests: fix common filter " Eric Sandeen
2013-04-22 13:45 ` Rich Johnston
2013-04-22 14:36 ` [PATCH] xfstests: remove recursive " Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox