Linux Btrfs filesystem development
 help / color / mirror / Atom feed
* Question on btrfs filesystem defragment args
@ 2013-04-26 16:08 Eric Sandeen
  0 siblings, 0 replies; only message in thread
From: Eric Sandeen @ 2013-04-26 16:08 UTC (permalink / raw)
  To: linux-btrfs; +Cc: Liu Bo

Liu Bo created test 284 for xfstests to exercise btrfs defragmentation.

One test sends an argument including "-s -1" meaning "start at negative one"

That's failing today, because parse_size now rejects negative numbers.
(that might be something to fix on its own, since length = (u64)-1
might imply the whole file, per kernel comments).

But has "start at -1" ever had an expected meaning?  That doesn't make
sense to me, but the test does it:

+echo "a single file | start < 0 && 0 < len < file size | off"
+_rundefrag 1 2 1

...

+_btrfs_online_defrag()
+{
+       str=""
+       if [ "$2" = "2" ];then
+               str="$str -s -1 -l $((filesize / 2)) "

and expects a silent result:

...
+a single file | default |  on
+a single file | start < 0 && 0 < len < file size | off
+a single file | start > file size && 0 < len < file size | off
...

What was this test intended to do when it was written?

Thanks,
-Eric

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-04-26 16:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-26 16:08 Question on btrfs filesystem defragment args Eric Sandeen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox