public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Mark Harmstone <maharmstone@meta.com>,
	"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"zlang@kernel.org" <zlang@kernel.org>
Cc: "neelx@suse.com" <neelx@suse.com>,
	"Johannes.Thumschirn@wdc.com" <Johannes.Thumschirn@wdc.com>
Subject: Re: [PATCH v4 2/2] btrfs: add test for encoded reads
Date: Fri, 10 Jan 2025 22:51:10 +0530	[thread overview]
Message-ID: <5211cb15-ffe9-49ff-bea1-30750c4bc2c9@oracle.com> (raw)
In-Reply-To: <92429a09-4ee9-4561-8c0b-4e8abdc78f57@meta.com>



On 10/1/25 22:09, Mark Harmstone wrote:
> On 8/1/25 06:33, Anand Jain wrote:
>>>
>> On 6/1/25 19:31, Mark Harmstone wrote:
>>> Add btrfs/333 and its helper programs btrfs_encoded_read and
>>> btrfs_encoded_write, in order to test encoded reads.
>>>
>>> We use the BTRFS_IOC_ENCODED_WRITE ioctl to write random data into a
>>> compressed extent, then use the BTRFS_IOC_ENCODED_READ ioctl to check
>>> that it matches what we've written. If the new io_uring interface for
>>> encoded reads is supported, we also check that that matches the ioctl.
>>>
>>> Note that what we write isn't valid compressed data, so any non-encoded
>>> reads on these files will fail.
>>>
>>> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
>>> ---
>>
>>
>> Looks good. Add to the group io_uring and ioctl.
>>
>> Reviewed-by: Anand Jain <anand.jain@oracle.com>
>>
>> Thx.
> 
> Thanks Anand.
> 
> Zorro, can you please add io_uring and ioctl to the _begin_fstest line?
> Or do you want me to resubmit?
> 

It has already been added to the local testing fstests repo, and the PR 
has been submitted.

https://github.com/asj/fstests.git staged-20250109

Thx.

> Thanks
> 
> Mark


  reply	other threads:[~2025-01-10 17:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 14:01 [PATCH v4 1/2] configure: use pkg-config to find liburing Mark Harmstone
2025-01-06 14:01 ` [PATCH v4 2/2] btrfs: add test for encoded reads Mark Harmstone
2025-01-08  6:33   ` Anand Jain
2025-01-10 16:39     ` Mark Harmstone
2025-01-10 17:21       ` Anand Jain [this message]
2025-01-10 19:10       ` Zorro Lang
2025-01-13  9:59         ` Mark Harmstone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5211cb15-ffe9-49ff-bea1-30750c4bc2c9@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=Johannes.Thumschirn@wdc.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=maharmstone@meta.com \
    --cc=neelx@suse.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox