Re: [PATCH v4 2/2] btrfs: add test for encoded reads

[Mark Harmstone <maharmstone@meta.com>]

On 10/1/25 19:10, Zorro Lang wrote:
> > 
> On Fri, Jan 10, 2025 at 04:39:29PM +0000, Mark Harmstone wrote:
>> On 8/1/25 06:33, Anand Jain wrote:
>>>>
>>> On 6/1/25 19:31, Mark Harmstone wrote:
>>>> Add btrfs/333 and its helper programs btrfs_encoded_read and
>>>> btrfs_encoded_write, in order to test encoded reads.
>>>>
>>>> We use the BTRFS_IOC_ENCODED_WRITE ioctl to write random data into a
>>>> compressed extent, then use the BTRFS_IOC_ENCODED_READ ioctl to check
>>>> that it matches what we've written. If the new io_uring interface for
>>>> encoded reads is supported, we also check that that matches the ioctl.
>>>>
>>>> Note that what we write isn't valid compressed data, so any non-encoded
>>>> reads on these files will fail.
>>>>
>>>> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
>>>> ---
>>>
>>>
>>> Looks good. Add to the group io_uring and ioctl.
>>>
>>> Reviewed-by: Anand Jain <anand.jain@oracle.com>
>>>
>>> Thx.
>>
>> Thanks Anand.
>>
>> Zorro, can you please add io_uring and ioctl to the _begin_fstest line?
>> Or do you want me to resubmit?
> 
> It's been added by Anand, I've merged it. Also I'd like to remove below lines:
> 
>    . ./common/filter
>    . ./common/btrfs
> 
>    _supported_fs btrfs
> 

Thanks Zorro. If it still works with them removed, sure.

Mark

> Thanks,
> Zorro
> 
>>
>> Thanks
>>
>> Mark
>>
>