Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: WorMzy Tykashi <wormzy.tykashi@gmail.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test
Date: Thu, 9 Apr 2015 09:43:02 +0800	[thread overview]
Message-ID: <5525D926.1050405@cn.fujitsu.com> (raw)
In-Reply-To: <CALOYprWfYKJG-9d=J9WLEisWLcpcKwv4bPwfcjggw-EC4phbGA@mail.gmail.com>

> Currently this test uses the system btrfs-image. If there isn't a
> btrfs-image on $PATH, the test fails. The test should be using the
> locally compiled btrfs-image, not the system one.
Good catch.

Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Thanks,
Qu
> ---
>
> diff --git a/tests/fsck-tests/012-leaf-corruption/test.sh
> b/tests/fsck-tests/012-leaf-corruption/test.sh
> index 4db4710..98e3185 100755
> --- a/tests/fsck-tests/012-leaf-corruption/test.sh
> +++ b/tests/fsck-tests/012-leaf-corruption/test.sh
> @@ -37,7 +37,7 @@ generate_leaf_corrupt_no_data_ext()
>       echo "generating leaf_corrupt_no_data_ext.btrfs-image" >> $RESULTS
>       tar xJf ./no_data_extent.tar.xz || \
>           _fail "failed to extract leaf_corrupt_no_data_ext.btrfs-image"
> -    btrfs-image -r test.img.btrfs-image $dest || \
> +    $TOP/btrfs-image -r test.img.btrfs-image $dest || \
>           _fail "failed to extract leaf_corrupt_no_data_ext.btrfs-image"
>
>       # leaf at 20832256 contains no regular data extent, clear its csum to
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2015-04-09  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 14:50 [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test WorMzy Tykashi
2015-04-09  1:43 ` Qu Wenruo [this message]
2015-04-09 16:45 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5525D926.1050405@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wormzy.tykashi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox