* [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test
@ 2015-04-08 14:50 WorMzy Tykashi
2015-04-09 1:43 ` Qu Wenruo
2015-04-09 16:45 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: WorMzy Tykashi @ 2015-04-08 14:50 UTC (permalink / raw)
To: linux-btrfs@vger.kernel.org
Currently this test uses the system btrfs-image. If there isn't a
btrfs-image on $PATH, the test fails. The test should be using the
locally compiled btrfs-image, not the system one.
---
diff --git a/tests/fsck-tests/012-leaf-corruption/test.sh
b/tests/fsck-tests/012-leaf-corruption/test.sh
index 4db4710..98e3185 100755
--- a/tests/fsck-tests/012-leaf-corruption/test.sh
+++ b/tests/fsck-tests/012-leaf-corruption/test.sh
@@ -37,7 +37,7 @@ generate_leaf_corrupt_no_data_ext()
echo "generating leaf_corrupt_no_data_ext.btrfs-image" >> $RESULTS
tar xJf ./no_data_extent.tar.xz || \
_fail "failed to extract leaf_corrupt_no_data_ext.btrfs-image"
- btrfs-image -r test.img.btrfs-image $dest || \
+ $TOP/btrfs-image -r test.img.btrfs-image $dest || \
_fail "failed to extract leaf_corrupt_no_data_ext.btrfs-image"
# leaf at 20832256 contains no regular data extent, clear its csum to
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test
2015-04-08 14:50 [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test WorMzy Tykashi
@ 2015-04-09 1:43 ` Qu Wenruo
2015-04-09 16:45 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Qu Wenruo @ 2015-04-09 1:43 UTC (permalink / raw)
To: WorMzy Tykashi, linux-btrfs@vger.kernel.org
> Currently this test uses the system btrfs-image. If there isn't a
> btrfs-image on $PATH, the test fails. The test should be using the
> locally compiled btrfs-image, not the system one.
Good catch.
Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Thanks,
Qu
> ---
>
> diff --git a/tests/fsck-tests/012-leaf-corruption/test.sh
> b/tests/fsck-tests/012-leaf-corruption/test.sh
> index 4db4710..98e3185 100755
> --- a/tests/fsck-tests/012-leaf-corruption/test.sh
> +++ b/tests/fsck-tests/012-leaf-corruption/test.sh
> @@ -37,7 +37,7 @@ generate_leaf_corrupt_no_data_ext()
> echo "generating leaf_corrupt_no_data_ext.btrfs-image" >> $RESULTS
> tar xJf ./no_data_extent.tar.xz || \
> _fail "failed to extract leaf_corrupt_no_data_ext.btrfs-image"
> - btrfs-image -r test.img.btrfs-image $dest || \
> + $TOP/btrfs-image -r test.img.btrfs-image $dest || \
> _fail "failed to extract leaf_corrupt_no_data_ext.btrfs-image"
>
> # leaf at 20832256 contains no regular data extent, clear its csum to
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test
2015-04-08 14:50 [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test WorMzy Tykashi
2015-04-09 1:43 ` Qu Wenruo
@ 2015-04-09 16:45 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2015-04-09 16:45 UTC (permalink / raw)
To: WorMzy Tykashi; +Cc: linux-btrfs@vger.kernel.org
On Wed, Apr 08, 2015 at 03:50:04PM +0100, WorMzy Tykashi wrote:
> Currently this test uses the system btrfs-image. If there isn't a
> btrfs-image on $PATH, the test fails. The test should be using the
> locally compiled btrfs-image, not the system one.
Added your sign-off and applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-09 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-08 14:50 [PATCH] btrfs-progs: use local btrfs-image in leaf corruption test WorMzy Tykashi
2015-04-09 1:43 ` Qu Wenruo
2015-04-09 16:45 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox