Linux Btrfs filesystem development
 help / color / mirror / Atom feed
* btrfs device ready non-success exit code
@ 2015-06-04 17:57 Roger Binns
  2015-06-04 23:25 ` Anand Jain
  0 siblings, 1 reply; 3+ messages in thread
From: Roger Binns @ 2015-06-04 17:57 UTC (permalink / raw)
  To: linux-btrfs

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This is on current Ubuntu 15.04.  What is device ready unhappy with?
Note that the root filesystem and /home (both subvolumes of this) are
mounted and working perfectly, and even where the commands are run from.

$ sudo btrfs fi show /dev/sda1
Label: 'main'  uuid: 3ff68715-0daa-4e44-8de2-0997f36d8ab6
	Total devices 2 FS bytes used 417.22GiB
	devid    2 size 894.25GiB used 362.03GiB path /dev/sdb1
	devid    3 size 894.25GiB used 362.03GiB path /dev/sda1

Btrfs v3.17
$ sudo btrfs fi show /
Label: 'main'  uuid: 3ff68715-0daa-4e44-8de2-0997f36d8ab6
	Total devices 2 FS bytes used 417.22GiB
	devid    2 size 894.25GiB used 362.03GiB path /dev/sdb1
	devid    3 size 894.25GiB used 362.03GiB path /dev/sda1

Btrfs v3.17
$ sudo btrfs device ready /dev/sda1 ; echo $?
1
$ sudo btrfs device ready /dev/sdb1 ; echo $?
1
$ uname -a
Linux workstation 3.19.0-18-generic #18-Ubuntu SMP Tue May 19 18:31:35
UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Roger
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlVwkX4ACgkQmOOfHg372QTEjQCgmhFU8Gxx8VOeNay2fkJjgpaU
ZOEAn18pogQVQnS8AzPzSEY7gu6rH+q3
=foM6
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: btrfs device ready non-success exit code
  2015-06-04 17:57 btrfs device ready non-success exit code Roger Binns
@ 2015-06-04 23:25 ` Anand Jain
  2015-06-05  3:04   ` Roger Binns
  0 siblings, 1 reply; 3+ messages in thread
From: Anand Jain @ 2015-06-04 23:25 UTC (permalink / raw)
  To: Roger Binns, linux-btrfs



On 06/05/2015 01:57 AM, Roger Binns wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> This is on current Ubuntu 15.04.  What is device ready unhappy with?
> Note that the root filesystem and /home (both subvolumes of this) are
> mounted and working perfectly, and even where the commands are run from.
>
> $ sudo btrfs fi show /dev/sda1
> Label: 'main'  uuid: 3ff68715-0daa-4e44-8de2-0997f36d8ab6
> 	Total devices 2 FS bytes used 417.22GiB
> 	devid    2 size 894.25GiB used 362.03GiB path /dev/sdb1
> 	devid    3 size 894.25GiB used 362.03GiB path /dev/sda1
>
> Btrfs v3.17
> $ sudo btrfs fi show /
> Label: 'main'  uuid: 3ff68715-0daa-4e44-8de2-0997f36d8ab6
> 	Total devices 2 FS bytes used 417.22GiB
> 	devid    2 size 894.25GiB used 362.03GiB path /dev/sdb1
> 	devid    3 size 894.25GiB used 362.03GiB path /dev/sda1
>
> Btrfs v3.17
> $ sudo btrfs device ready /dev/sda1 ; echo $?
> 1
> $ sudo btrfs device ready /dev/sdb1 ; echo $?
> 1


typically ready cli is to check disk pool status in an unmounted state.

Strictly we wanted ready cli to be a read only cli, but it updates the 
device path as well, which eventually I think we will fix it, if the
systemd won't compliant about it.

-Anand


> $ uname -a
> Linux workstation 3.19.0-18-generic #18-Ubuntu SMP Tue May 19 18:31:35
> UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
>
> Roger
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iEYEARECAAYFAlVwkX4ACgkQmOOfHg372QTEjQCgmhFU8Gxx8VOeNay2fkJjgpaU
> ZOEAn18pogQVQnS8AzPzSEY7gu6rH+q3
> =foM6
> -----END PGP SIGNATURE-----
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: btrfs device ready non-success exit code
  2015-06-04 23:25 ` Anand Jain
@ 2015-06-05  3:04   ` Roger Binns
  0 siblings, 0 replies; 3+ messages in thread
From: Roger Binns @ 2015-06-05  3:04 UTC (permalink / raw)
  To: linux-btrfs

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/04/2015 04:25 PM, Anand Jain wrote:
>> typically ready cli is to check disk pool status in an unmounted
>> state.

On my desktop with btrfs RAID0 on two partitions, the exit code of
ready is always 1.  On my laptop with btrfs RAID0 on two LUKS/dmcrypt
partitions the exit code is 0.  (In both cases there are / and /home
already mounted as subvolumes.)

The documentation says:

  Check device to see if it has all of it’s devices in
  cache for mounting

The semantics implied by that are that a successful return means you
can mount the device(s).  Consequently if already mounted, surely it
should return success?

Roger
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlVxEakACgkQmOOfHg372QTIKwCgwKJIqjNWJH/FMfVtm1Ktesxz
E5YAnjxMP8VyfuLPM2fmfxU8UuuyDpGi
=Axi1
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-05  3:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-04 17:57 btrfs device ready non-success exit code Roger Binns
2015-06-04 23:25 ` Anand Jain
2015-06-05  3:04   ` Roger Binns

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox