From: Josef Bacik <jbacik@fb.com>
To: adam900710 <adam900710@gmail.com>
Cc: Chris Mason <clm@fb.com>, <quwenruo@cn.fujitsu.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [GIT PULL] Qgroup rework with other Fujitsu fix.
Date: Tue, 9 Jun 2015 10:54:54 -0400 [thread overview]
Message-ID: <5576FE3E.9050202@fb.com> (raw)
In-Reply-To: <CAFy8SQW58c7DUUod7FaiNtY2MaoY6ZYt3jacG-RQHJZx+4so7A@mail.gmail.com>
On 06/09/2015 10:23 AM, adam900710 wrote:
> Sorry, forgot to reply to all.
>
> To Josef,
>
> I am afraid that your conclusion is not right, as in the patch, it will
> only merge delayed refs when they are in same sequence number.
>
> In fact, in the patch, conditions for merge is even more restrict than
> before, it will not allow merging delayed refs for the same extent if
> there are other delayed refs between them.
>
You're right, I missed this bit
+ if (exist->type != ref->type || exist->no_quota != ref->no_quota ||
+ exist->seq != ref->seq)
+ goto add_tail;
I don't want the merging more strict, I want to merge as much as
possible, this was the problem with the original qgroup work and that's
why I reworked all this sequence number crap. Thanks,
Josef
next prev parent reply other threads:[~2015-06-09 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 3:06 [GIT PULL] Qgroup rework with other Fujitsu fix Qu Wenruo
2015-06-09 6:03 ` Wang Shilong
2015-06-09 7:09 ` Qu Wenruo
2015-06-24 6:54 ` Qu Wenruo
2015-06-09 14:10 ` Josef Bacik
[not found] ` <CAFy8SQW58c7DUUod7FaiNtY2MaoY6ZYt3jacG-RQHJZx+4so7A@mail.gmail.com>
2015-06-09 14:54 ` Josef Bacik [this message]
2015-06-10 0:33 ` Qu Wenruo
2015-06-10 0:33 ` Qu Wenruo
2015-06-10 20:45 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5576FE3E.9050202@fb.com \
--to=jbacik@fb.com \
--cc=adam900710@gmail.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox