* next-20210511 - btrfs build failure on arm
@ 2021-05-11 18:08 Valdis Klētnieks
2021-05-11 18:09 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2021-05-11 18:08 UTC (permalink / raw)
To: Qu Wenruo, David Sterba
Cc: linux-btrfs, linux-kernel, Chris Mason, Josef Bacik
An arm allmodconfig build died with:
ERROR: modpost: "__aeabi_uldivmod" [fs/btrfs/btrfs.ko] undefined!
Some digging around with nm and looking at the assembler points at:
@ /usr/src/linux-next/fs/btrfs/extent_io.c:2676: const int nr_bits = (end + 1 - start) / fs_info->sectorsize_bits;
adds r1, r1, #1 @, tmp552,
adc r0, r0, #0 @, tmp551,
ldr r3, [r5, #1576] @ tmp2, _47->sectorsize_bits
bl __aeabi_uldivmod @
Introduced by this commit:
commit 6512659d8f13015dccfb38a13c6d117d22572019
Author: Qu Wenruo <wqu@suse.com>
Date: Mon May 3 10:08:55 2021 +0800
btrfs: submit read time repair only for each corrupted sector
Looks like that line could use something from include/linux/math.h
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: next-20210511 - btrfs build failure on arm
2021-05-11 18:08 next-20210511 - btrfs build failure on arm Valdis Klētnieks
@ 2021-05-11 18:09 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2021-05-11 18:09 UTC (permalink / raw)
To: Valdis Klētnieks
Cc: Qu Wenruo, David Sterba, linux-btrfs, linux-kernel, Chris Mason,
Josef Bacik
On Tue, May 11, 2021 at 02:08:02PM -0400, Valdis Klētnieks wrote:
> An arm allmodconfig build died with:
>
> ERROR: modpost: "__aeabi_uldivmod" [fs/btrfs/btrfs.ko] undefined!
>
> Some digging around with nm and looking at the assembler points at:
>
> @ /usr/src/linux-next/fs/btrfs/extent_io.c:2676: const int nr_bits = (end + 1 - start) / fs_info->sectorsize_bits;
> adds r1, r1, #1 @, tmp552,
> adc r0, r0, #0 @, tmp551,
> ldr r3, [r5, #1576] @ tmp2, _47->sectorsize_bits
> bl __aeabi_uldivmod @
>
> Introduced by this commit:
>
> commit 6512659d8f13015dccfb38a13c6d117d22572019
> Author: Qu Wenruo <wqu@suse.com>
> Date: Mon May 3 10:08:55 2021 +0800
>
> btrfs: submit read time repair only for each corrupted sector
>
> Looks like that line could use something from include/linux/math.h
We got another report already, there's division instead of shift (a
mistake), so the expression would require u64/u32 division. The correct
one is (end + 1 - start) >> fs_info->sectorsize_bits; and will be fixed
in upcoming next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-11 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-11 18:08 next-20210511 - btrfs build failure on arm Valdis Klētnieks
2021-05-11 18:09 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox