[PATCH] btrfs: fix misleading warning when space cache failed to load

[PATCH] btrfs: fix misleading warning when space cache failed to load

[Holger Hoffstätte]

When an inconsistent space cache is detected during loading we log a
warning that users frequently mistake as instruction to invalidate the
cache manually, even though this is not required. Fix the message to
indicate that the cache will be rebuilt automatically.

Signed-off-by: Holger Hoffstätte <holger.hoffstaette@googlemail.com>
---
 fs/btrfs/free-space-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index 0948d34..7a91770 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -891,7 +891,7 @@ out:
 		spin_unlock(&block_group->lock);
 		ret = 0;
 
-		btrfs_warn(fs_info, "failed to load free space cache for block group %llu, rebuild it now",
+		btrfs_warn(fs_info, "failed to load free space cache for block group %llu, rebuilding it now",
 			block_group->key.objectid);
 	}
 
-- 
2.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-

Re: [PATCH] btrfs: fix misleading warning when space cache failed to load

[Duncan]

Holger Hoffstätte posted on Fri, 27 Nov 2015 17:32:04 +0100 as excerpted:

> When an inconsistent space cache is detected during loading we log a
> warning that users frequently mistake as instruction to invalidate the
> cache manually, even though this is not required. Fix the message to
> indicate that the cache will be rebuilt automatically.
> 
> Signed-off-by: Holger Hoffstätte <holger.hoffstaette@googlemail.com>

+1.  The message as-is, /is/ confusing, and this fixes it. =:^)

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman