From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
To: dsterba@suse.cz, Qu Wenruo <quwenruo@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] btrfs: Introduce new mount option to disable tree log replay
Date: Mon, 14 Dec 2015 12:50:37 -0500 [thread overview]
Message-ID: <566F016D.8050403@gmail.com> (raw)
In-Reply-To: <20151214173200.GO4227@twin.jikos.cz>
On 2015-12-14 12:32, David Sterba wrote:
> On Thu, Dec 10, 2015 at 10:34:06AM +0800, Qu Wenruo wrote:
>> Introduce a new mount option "nologreplay" to co-operate with "ro" mount
>> option to get real readonly mount, like "norecovery" in ext* and xfs.
>>
>> Since the new parse_options() need to check new flags at remount time,
>> so add a new parameter for parse_options().
>>
>> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
>> Reviewed-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>> Tested-by: Austin S. Hemmelgarn <ahferroin7@gmail.com>
>
> I've read the discussions around the change and from the user's POV I'd
> suggest to add another mount option that would be just an alias for any
> mount options that would implement the 'hard-ro' semantics.
>
> Say it's called 'nowr'. Now it would imply 'nologreplay', but may cover
> more options in the future.
It should also imply noatime. I'm not sure how BTRFS handles atime when
mounted RO, but I know a lot of old UNIX systems updated atime even on
filesystems mounted RO, and I know that at least at one point Linux did too.
>
> mount -o ro,nowr /dev/sdx /mnt
>
> would work when switching kernels.
I like this idea, but I think that having a name like true-ro or hard-ro
and making it imply ro (and noatime) would probably be better (or at
least, simpler to use from a user perspective).
next prev parent reply other threads:[~2015-12-14 17:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 2:34 [PATCH v3] btrfs: Introduce new mount option to disable tree log replay Qu Wenruo
2015-12-14 17:32 ` David Sterba
2015-12-14 17:50 ` Austin S. Hemmelgarn [this message]
2015-12-14 19:16 ` Christoph Anton Mitterer
2015-12-14 19:33 ` Austin S. Hemmelgarn
2015-12-14 19:44 ` Christoph Anton Mitterer
2015-12-14 20:20 ` Austin S. Hemmelgarn
2015-12-14 23:34 ` Christoph Anton Mitterer
2015-12-15 13:31 ` Austin S. Hemmelgarn
2015-12-16 13:53 ` David Sterba
2015-12-14 19:11 ` Christoph Anton Mitterer
2015-12-16 1:36 ` Qu Wenruo
2015-12-16 2:13 ` Christoph Anton Mitterer
2015-12-16 11:10 ` Duncan
2015-12-16 11:45 ` Christoph Anton Mitterer
2015-12-17 1:09 ` Duncan
2015-12-17 1:46 ` Christoph Anton Mitterer
2015-12-16 12:12 ` Austin S. Hemmelgarn
2015-12-16 12:34 ` Christoph Anton Mitterer
2015-12-16 12:57 ` Austin S. Hemmelgarn
2015-12-16 13:01 ` Christoph Anton Mitterer
2015-12-16 13:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566F016D.8050403@gmail.com \
--to=ahferroin7@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox