Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: Naohiro Aota <naohiro.aota@wdc.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 1/4] btrfs-progs: tests: output error/warn message to stderr
Date: Wed, 10 Sep 2025 14:52:20 +0930	[thread overview]
Message-ID: <595f3fb8-6fbc-4e22-8eea-0e6248be73bc@suse.com> (raw)
In-Reply-To: <20250910050412.2138579-2-naohiro.aota@wdc.com>



在 2025/9/10 14:34, Naohiro Aota 写道:
> Outputting these messages to stdout can compromise the functions' output.
> Instead, output them to stderr to keep the results clean.
> 
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   tests/nullb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/nullb b/tests/nullb
> index 457ae0d8354a..f3cdf9c19e16 100755
> --- a/tests/nullb
> +++ b/tests/nullb
> @@ -34,12 +34,12 @@ SYSFS='/sys/kernel/config/nullb'
>   # setup
>   
>   function _error() {
> -	echo "ERROR: $@"
> +	echo "ERROR: $@" 1>&2
>   	exit 1
>   }
>   
>   function _warn() {
> -	echo "WARNING: $@"
> +	echo "WARNING: $@" 1>&2
>   }
>   
>   function _msg() {


  reply	other threads:[~2025-09-10  5:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10  5:04 [PATCH v2 0/4] btrfs-progs: tests: add new mkfs test for zoned device Naohiro Aota
2025-09-10  5:04 ` [PATCH v2 1/4] btrfs-progs: tests: output error/warn message to stderr Naohiro Aota
2025-09-10  5:22   ` Qu Wenruo [this message]
2025-09-10  5:04 ` [PATCH v2 2/4] btrfs-progs: tests: check nullb index for the error case Naohiro Aota
2025-09-10  5:22   ` Qu Wenruo
2025-09-10  5:04 ` [PATCH v2 3/4] btrfs-progs: tests: add wait_for_nullbdevs Naohiro Aota
2025-09-10  5:22   ` Qu Wenruo
2025-09-10  5:04 ` [PATCH v2 4/4] btrfs-progs: tests: add new mkfs test for zoned device Naohiro Aota
2025-10-16 17:53 ` [PATCH v2 0/4] " David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=595f3fb8-6fbc-4e22-8eea-0e6248be73bc@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox